Skip to content

Commit

Permalink
Auto merge of #62279 - pietroalbini:fix-azure-crlf, r=alexcrichton
Browse files Browse the repository at this point in the history
ci: explicitly disable CRLF conversion on Windows

The Azure image enables CRLF conversion on Windows builders, but that caused regressions both in our test suite (the miri test suite broke) and in the ecosystem, since we started shipping install scripts with CRLF endings instead of the old LF. The [Godbolt Compiler Explorer](https://godbolt.org/) is one such case of breakage.

This adds a step to the build explicitly disabling the conversion before the repository is checked out.

r? @alexcrichton
cc @gnzlbg
  • Loading branch information
bors committed Jul 1, 2019
2 parents 17e62f7 + 239a404 commit 99abdfa
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .azure-pipelines/steps/run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@

steps:

# Disable automatic line ending conversion, which is enabled by default on
# Azure's Windows image. Having the conversion enabled caused regressions both
# in our test suite (it broke miri tests) and in the ecosystem, since we
# started shipping install scripts with CRLF endings instead of the old LF.
- bash: git config --global core.autocrlf false
displayName: "Disable git automatic line ending conversion"

- checkout: self
fetchDepth: 2

Expand Down

0 comments on commit 99abdfa

Please sign in to comment.