Skip to content

Commit

Permalink
Fix private::exclusive_unwrap_conflict test. Fixes #4689.
Browse files Browse the repository at this point in the history
  • Loading branch information
bblum committed Feb 22, 2013
1 parent e0767bf commit 9dae4cf
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/libcore/private.rs
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ pub mod tests {
res.recv();
}
#[test] #[should_fail] #[ignore(reason = "random red")]
#[test] #[should_fail] #[ignore(cfg(windows))]
pub fn exclusive_unwrap_conflict() {
let x = exclusive(~~"hello");
let x2 = ~mut Some(x.clone());
Expand All @@ -505,7 +505,8 @@ pub mod tests {
}
assert unwrap_exclusive(x) == ~~"hello";
let res = option::swap_unwrap(&mut res);
res.recv();
// See #4689 for why this can't be just "res.recv()".
assert res.recv() == task::Success;
}
#[test] #[ignore(cfg(windows))]
Expand Down

5 comments on commit 9dae4cf

@bors
Copy link
Contributor

@bors bors commented on 9dae4cf Feb 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from brson
at bblum@9dae4cf

@bors
Copy link
Contributor

@bors bors commented on 9dae4cf Feb 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging bblum/rust/incoming = 9dae4cf into auto

@bors
Copy link
Contributor

@bors bors commented on 9dae4cf Feb 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bblum/rust/incoming = 9dae4cf merged ok, testing candidate = 1bc4e3f

@bors
Copy link
Contributor

@bors bors commented on 9dae4cf Feb 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 9dae4cf Feb 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding incoming to auto = 1bc4e3f

Please sign in to comment.