Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Native timers are a much hairier thing to deal with than green timers due to the interface that we would like to expose (both a blocking sleep() and a channel-based interface). I ended up implementing timers in three different ways for the various platforms that we supports. In all three of the implementations, there is a worker thread which does send()s on channels for timers. This worker thread is initialized once and then communicated to in a platform-specific manner, but there's always a shared channel available for sending messages to the worker thread. * Windows - I decided to use windows kernel timer objects via CreateWaitableTimer and SetWaitableTimer in order to provide sleeping capabilities. The worker thread blocks via WaitForMultipleObjects where one of the objects is an event that is used to wake up the helper thread (which then drains the incoming message channel for requests). * Linux/(Android?) - These have the ideal interface for implementing timers, timerfd_create. Each timer corresponds to a timerfd, and the helper thread uses epoll to wait for all active timers and then send() for the next one that wakes up. The tricky part in this implementation is updating a timerfd, but see the implementation for the fun details * OSX/FreeBSD - These obviously don't have the windows APIs, and sadly don't have the timerfd api available to them, so I have thrown together a solution which uses select() plus a timeout in order to ad-hoc-ly implement a timer solution for threads. The implementation is backed by a sorted array of timers which need to fire. As I said, this is an ad-hoc solution which is certainly not accurate timing-wise. I have done this implementation due to the lack of other primitives to provide an implementation, and I've done it the best that I could, but I'm sure that there's room for improvement. I'm pretty happy with how these implementations turned out. In theory we could drop the timerfd implementation and have linux use the select() + timeout implementation, but it's so inaccurate that I would much rather continue to use timerfd rather than my ad-hoc select() implementation. The only change that I would make to the API in general is to have a generic sleep() method on an IoFactory which doesn't require allocating a Timer object. For everything but windows it's super-cheap to request a blocking sleep for a set amount of time, and it's probably worth it to provide a sleep() which doesn't do something like allocate a file descriptor on linux.
- Loading branch information
b8e4383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@b8e4383
b8e4383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/native-timer = b8e4383 into auto
b8e4383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/native-timer = b8e4383 merged ok, testing candidate = 5b98bbee
b8e4383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/3498
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3720
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/1564
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3721
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2827
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3735
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2829
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3737
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2828
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/3727
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2833
b8e4383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@b8e4383
b8e4383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/native-timer = b8e4383 into auto
b8e4383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/native-timer = b8e4383 merged ok, testing candidate = 7ea063e
b8e4383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3721
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/1563
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/1565
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3722
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2822
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2828
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3736
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2824
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2830
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3738
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2824
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2829
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/2898
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/3728
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/2829
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2834
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/3499
b8e4383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 7ea063e