Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove the "NFKC clause" in the reference manual.
The reference manual said that code is interpreted as UTF-8 text and a implementation will normalize it to NFKC. However, rustc doesn't do any normalization now. We may want to do any normalization for symbols, but normalizing whole text seems harmful because doing so loses some sort of information even if we choose a non-K variant of normalization. I'd suggest removing "normalized to Unicode normalization form NFKC" phrase for the present so that the manual represents the current state properly. When we address the problem (with a RFC?), then the manual should be updated. Closes #12388. Reference: #2253 Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
- Loading branch information
bf2d98e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at https://github.com/omasanori/rust/commit/bf2d98e1900d854b88192a439993161c665881fe
bf2d98e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging omasanori/rust/nfkc = bf2d98e into auto
bf2d98e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omasanori/rust/nfkc = bf2d98e merged ok, testing candidate = 157459b
bf2d98e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/687
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/687
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/686
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/687
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/684
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/685
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/684
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/690
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/685
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/684
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/687
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/685
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/685
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/686
bf2d98e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 157459b