-
Notifications
You must be signed in to change notification settings - Fork 13k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
detect incorrect vtable alignment during const eval instead of ICE-ing
also add tests for these 2 kinds of errors for size and alignment, as the existing size check wasn't apparently tested
- Loading branch information
Showing
3 changed files
with
51 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// This test contains code with incorrect vtables in a const context: | ||
// - from issue 86132: a trait object with invalid alignment caused an ICE in const eval, and now | ||
// triggers an error | ||
// - a similar test that triggers a previously-untested const UB error: emitted close to the above | ||
// error, it checks the correctness of the size | ||
|
||
trait Trait {} | ||
|
||
const INVALID_VTABLE_ALIGNMENT: &dyn Trait = | ||
unsafe { std::mem::transmute((&92u8, &[0usize, 1usize, 1000usize])) }; | ||
//~^ ERROR any use of this value will cause an error | ||
//~| WARNING this was previously accepted by the compiler | ||
//~| invalid vtable: alignment `1000` is not a power of 2 | ||
|
||
const INVALID_VTABLE_SIZE: &dyn Trait = | ||
unsafe { std::mem::transmute((&92u8, &[1usize, usize::MAX, 1usize])) }; | ||
//~^ ERROR any use of this value will cause an error | ||
//~| WARNING this was previously accepted by the compiler | ||
//~| invalid vtable: size is bigger than largest supported object | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
error: any use of this value will cause an error | ||
--> $DIR/ub-incorrect-vtable.rs:10:14 | ||
| | ||
LL | / const INVALID_VTABLE_ALIGNMENT: &dyn Trait = | ||
LL | | unsafe { std::mem::transmute((&92u8, &[0usize, 1usize, 1000usize])) }; | ||
| |______________^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^__- | ||
| | | ||
| invalid vtable: alignment `1000` is not a power of 2 | ||
| | ||
= note: `#[deny(const_err)]` on by default | ||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
= note: for more information, see issue #71800 <https://github.com/rust-lang/rust/issues/71800> | ||
|
||
error: any use of this value will cause an error | ||
--> $DIR/ub-incorrect-vtable.rs:16:14 | ||
| | ||
LL | / const INVALID_VTABLE_SIZE: &dyn Trait = | ||
LL | | unsafe { std::mem::transmute((&92u8, &[1usize, usize::MAX, 1usize])) }; | ||
| |______________^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^__- | ||
| | | ||
| invalid vtable: size is bigger than largest supported object | ||
| | ||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
= note: for more information, see issue #71800 <https://github.com/rust-lang/rust/issues/71800> | ||
|
||
error: aborting due to 2 previous errors | ||
|