-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename the NaN and is_NaN methods to lowercase.
This is for consistency in naming conventions. - ``std::num::Float::NaN()`` is changed to ``nan()``; - ``std::num::Float.is_NaN()`` is changed to ``is_nan()``; and - ``std::num::strconv::NumStrConv::NaN()`` is changed to ``nan()``. Fixes #9319.
- Loading branch information
1 parent
99ec14d
commit d9874c0
Showing
8 changed files
with
138 additions
and
138 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
d9874c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at chris-morgan@d9874c0
d9874c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging chris-morgan/rust/lowercase-nan-methods = d9874c0 into auto
d9874c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chris-morgan/rust/lowercase-nan-methods = d9874c0 merged ok, testing candidate = ccb80ab
d9874c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1595
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1598
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/704
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/704
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1613
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/704
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/704
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1613
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/704
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/705
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/785
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1598
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/704
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/705
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/1382
d9874c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = ccb80ab