Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactored take_unwrap (libstd/option.rs)
Using pattern matching instead of is_some + unwrap
- Loading branch information
ea8da6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from cmr
at https://github.com/aochagavia/rust/commit/ea8da6ed9743eb6cf047a1080c711bdceec93375
ea8da6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging aochagavia/rust/option-take_unwrap = ea8da6e into auto
ea8da6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aochagavia/rust/option-take_unwrap = ea8da6e merged ok, testing candidate = 62577b4a
ea8da6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3876
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/4783
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/3871
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3877
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/4785
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/3871
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/3944
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/4782
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/3883
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/3890
exception: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4544
ea8da6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from cmr
at https://github.com/aochagavia/rust/commit/ea8da6ed9743eb6cf047a1080c711bdceec93375
ea8da6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging aochagavia/rust/option-take_unwrap = ea8da6e into auto
ea8da6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aochagavia/rust/option-take_unwrap = ea8da6e merged ok, testing candidate = 9e89ffc
ea8da6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/4785
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/3873
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3879
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/4787
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/3873
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3878
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/3946
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/4784
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/3885
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/3892
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4546
ea8da6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 9e89ffc