Skip to content

Commit

Permalink
auto merge of #12586 : chris-morgan/rust/fix-pretty-print-slash-star-…
Browse files Browse the repository at this point in the history
…star-star-crash, r=alexcrichton

The pretty printer was treating block comments with more than two
asterisks after the first slash (e.g. `/***`) as doc comments (which are
attributes), whereas in actual fact they are just regular comments.
  • Loading branch information
bors committed Feb 27, 2014
2 parents b4d9238 + e6b032a commit fd02f90
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/libsyntax/parse/comments.rs
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ fn read_block_comment(rdr: &StringReader,
let mut curr_line = ~"/*";
// doc-comments are not really comments, they are attributes
if rdr.curr_is('*') || rdr.curr_is('!') {
if (rdr.curr_is('*') && !nextch_is(rdr, '*')) || rdr.curr_is('!') {
while !(rdr.curr_is('*') && nextch_is(rdr, '/')) && !is_eof(rdr) {
curr_line.push_char(rdr.curr.get().unwrap());
bump(rdr);
Expand Down
14 changes: 14 additions & 0 deletions src/test/pretty/block-comment-multiple-asterisks.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// pp-exact
/***
More than two asterisks means that it isn't a doc comment.
*/

0 comments on commit fd02f90

Please sign in to comment.