Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get LLVM to stop inlining free glue of @ boxes #10045

Closed
pcwalton opened this issue Oct 24, 2013 · 0 comments · Fixed by #10059
Closed

Get LLVM to stop inlining free glue of @ boxes #10045

pcwalton opened this issue Oct 24, 2013 · 0 comments · Fixed by #10059
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@pcwalton
Copy link
Contributor

This is becoming a big problem in Servo. cc @thestinger
@thestinger thestinger mentioned this issue Oct 25, 2013
Merged
bors added a commit that referenced this issue Oct 25, 2013
@bors
auto merge of #10059 : thestinger/rust/glue, r=pcwalton
c16a95c 
Closes #10045
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 1, 2023
@bors
Auto merge of rust-lang#11864 - GuillaumeGomez:option_map_or_err_ok, …
3664d63 
…r=flip1995

Create new lint `option_map_or_err_ok`

Fixes rust-lang#10045.

For the following code:

```rust
let opt = Some(1);
opt.map_or(Err("error"), Ok);
```

It suggests to instead write:

```rust
let opt = Some(1);
opt.ok_or("error");
```

r? `@flip1995`

changelog: Create new lint `option_map_or_err_ok`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stop trying to outsmart LLVM inline heuristics
1 participant
@pcwalton