Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize raw-dylib for non-x86 #102793

Closed
wesleywiser opened this issue Oct 7, 2022 · 6 comments
Closed

Stabilize raw-dylib for non-x86 #102793

wesleywiser opened this issue Oct 7, 2022 · 6 comments
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. F-raw_dylib `#![feature(raw_dylib)]` finished-final-comment-period The final comment period is finished for this PR / Issue. I-lang-nominated Nominated for discussion during a lang team meeting. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@wesleywiser
Copy link
Member

The raw-dylib feature was proposed for stabilization for non-x86 targets in #99916 which the compiler team FCP'd and merged but forgot to tag T-lang as well. Sorry about that!

Since that PR has already been FCP'd rfcbot won't allow me to start another FCP on it so I'm creating this issue to act as T-lang's FCP.

This stabilizes the raw-dylib and link_ordinal features (#58713) for non-x86 architectures (i.e., x86_64, aarch64 and thumbv7a)

Link to stabilization report

I'm also tagging this I-lang-nominated to ensure discussion of this happens prior to the next release so we can either confirm the stabilization of the feature or revert the stabilization before the next release.

@wesleywiser wesleywiser added T-lang Relevant to the language team, which will review and decide on the PR/issue. F-raw_dylib `#![feature(raw_dylib)]` I-lang-nominated Nominated for discussion during a lang team meeting. labels Oct 7, 2022
@joshtriplett
Copy link
Member

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Oct 7, 2022

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 7, 2022
@nikomatsakis
Copy link
Contributor

@rfcbot reviewed

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 11, 2022
@rfcbot
Copy link

rfcbot commented Oct 11, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 21, 2022
@rfcbot
Copy link

rfcbot commented Oct 21, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@wesleywiser
Copy link
Member Author

Since this already merged in #99916, I'm going to go ahead and close this issue.

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. F-raw_dylib `#![feature(raw_dylib)]` finished-final-comment-period The final comment period is finished for this PR / Issue. I-lang-nominated Nominated for discussion during a lang team meeting. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants