Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustpkg doesn't find libraries with missing sources #10430

Closed
wycats opened this issue Nov 11, 2013 · 5 comments
Closed

rustpkg doesn't find libraries with missing sources #10430

wycats opened this issue Nov 11, 2013 · 5 comments

Comments

@wycats
Copy link
Contributor

wycats commented Nov 11, 2013

I compiled an .so from source and put it into my lib directory, but rustpkg build didn't find it.

Please let me know if I can provide more details.

@catamorphism
Copy link
Contributor

To provide a little more detail, the code is:

extern mod protobuf;

pub fn main() {
world()
}

pub fn world() {
println("Hello, world")
}

Even if the compiled library protobuf is in a lib/ directory inside a workspace that's in the RUST_PATH, rustpkg won't find it, because it looks for sources first.

@z0w0
Copy link
Contributor

z0w0 commented Nov 13, 2013

@catamorphism any hints of the best place for it to check if a compiled library exists and handle appropiately? I was thinking path_util::workspace_contains_package_id but I'm not sure if a compiled library is exactly equivalent to a library package. It's been a while since I've been near rustpkg so I'm a bit lost..

@jakerr
Copy link
Contributor

jakerr commented Dec 31, 2013

rustpkg also fails to find the library native for this code:

extern mod native;

#[start]
fn start(argc: int, argv: **u8) -> int {
    do native::start(argc, argv) {
        main();
    }
}

pub fn main() {
    println("Hello, world")
}

giving the error:

error: Package hello depends on native, but I don't know how to find it

Maybe for the same reason, or is this a separate bug?

@jhasse
Copy link
Contributor

jhasse commented Jan 5, 2014

@jakerr Separate bug: #11330

@alexcrichton
Copy link
Member

rustpkg has been removed, closing

flip1995 pushed a commit to flip1995/rust that referenced this issue May 5, 2023
New lint: detect `if` expressions with simple boolean assignments to the same target

Closes rust-lang#10430

changelog: [`needless_bool_assign`] new lint to detect simple boolean assignment to the same target in `if` branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants