Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.py fmt is extremely noisy #106920

Closed
mejrs opened this issue Jan 15, 2023 · 6 comments · Fixed by #108778
Closed

x.py fmt is extremely noisy #106920

mejrs opened this issue Jan 15, 2023 · 6 comments · Fixed by #108778
Assignees
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@mejrs
Copy link
Contributor

mejrs commented Jan 15, 2023

Today I synchronized my local version of the rust repo, made a few changes and formatted.

This prints:

Building rustbuild
formatting modified file compiler/rustc_abi/src/lib.rs
formatting modified file compiler/rustc_ast/src/ast.rs
formatting modified file compiler/rustc_ast/src/ast_traits.rs
formatting modified file compiler/rustc_ast/src/attr/mod.rs

/* 35k lines omitted for brevity */

formatting modified file tests/ui/zero-sized/zero-sized-binary-heap-push.rs
formatting modified file tests/ui/zero-sized/zero-sized-btreemap-insert.rs
formatting modified file tests/ui/zero-sized/zero-sized-linkedlist-push.rs
formatting modified file tests/ui/zero-sized/zero-sized-tuple-struct.rs
Build completed successfully in 0:00:05
@albertlarsan68
Copy link
Member

This is a known issue, it means that you have a remote to the rust-lang repo that is outdated.
The 35k lines likely means that it is at least behind the test move.
Does running git fetch upstream (replace upstream with the remote name if different) fixes it ?

@Noratrieb Noratrieb added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jan 17, 2023
@chenyukang
Copy link
Member

Maybe we should remove these logs?

@albertlarsan68
Copy link
Member

There is the same problem if you created lots of file in the formatted directories, but did not track them in git:
It will print the name of all of these.

@jyn514
Copy link
Member

jyn514 commented Jan 23, 2023

I think we should avoid printing the names of the files if there are more than 10 (or whatever number). That would avoid all similar issues.

@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. labels Jan 23, 2023
@shourya5
Copy link
Contributor

@rustbot claim

@zephaniahong
Copy link
Contributor

@shourya5 Hi! May I know if you're still working on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants