Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x fmt: Don't print all modified files if there's more than 10 #108778

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Mar 5, 2023

This avoids spam for dozens of modified files.

Fixes #106920.

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 5, 2023
@jyn514 jyn514 changed the title Don't print all modified files if there's more than 10 x fmt: Don't print all modified files if there's more than 10 Mar 5, 2023
@albertlarsan68
Copy link
Member

albertlarsan68 commented Mar 5, 2023

r? @albertlarsan68
Thanks for the PR!
@bors rollup
r=me when CI green

@jyn514
Copy link
Member Author

jyn514 commented Mar 5, 2023

@bors r=albertlarsan68

Thanks!

@bors
Copy link
Contributor

bors commented Mar 5, 2023

📌 Commit 3081d5841d7b5aa1b347ad12eccd2f1f5eb2ec37 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2023
@albertlarsan68
Copy link
Member

@bors r-
Please address Mark's comment

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2023
This avoids spam for dozens of modified files.
@jyn514
Copy link
Member Author

jyn514 commented Mar 9, 2023

@bors r=albertlarsan68

@bors
Copy link
Contributor

bors commented Mar 9, 2023

📌 Commit eb9b031 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#106915 (Only load one CSS theme by default)
 - rust-lang#108294 (Place binder correctly for arbitrary trait bound suggestion)
 - rust-lang#108778 (x fmt: Don't print all modified files if there's more than 10)
 - rust-lang#108854 (feat/refactor: improve errors in case of ident with number at start)
 - rust-lang#108870 (Fix invalid inlining of reexport of reexport of private item)
 - rust-lang#108917 (Consider target_family as pal)
 - rust-lang#108922 (Add auto notification for changes to stable mir)
 - rust-lang#108929 (Fix typo in span_map.rs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit aedd94f into rust-lang:master Mar 10, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x.py fmt is extremely noisy
5 participants