Fix invalid inlining of reexport of reexport of private item #108870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
notriddle
reviewed
Mar 7, 2023
GuillaumeGomez
force-pushed
the
rustdoc-reexport-of-reexport-of-private
branch
from
0be91b6
to
cdfed47
Compare
|
Added and updated the documentation. |
notriddle
reviewed
Mar 7, 2023
GuillaumeGomez
force-pushed
the
rustdoc-reexport-of-reexport-of-private
branch
from
cdfed47
to
c0c93be
Compare
|
Updated! |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#106915 (Only load one CSS theme by default) - rust-lang#108294 (Place binder correctly for arbitrary trait bound suggestion) - rust-lang#108778 (x fmt: Don't print all modified files if there's more than 10) - rust-lang#108854 (feat/refactor: improve errors in case of ident with number at start) - rust-lang#108870 (Fix invalid inlining of reexport of reexport of private item) - rust-lang#108917 (Consider target_family as pal) - rust-lang#108922 (Add auto notification for changes to stable mir) - rust-lang#108929 (Fix typo in span_map.rs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108679.
The problem is that a reexport is always resolving to the end type, so if the end type is private, the reexport inlines. Except that if you reexport a public reexport (which reexports the private item), then it should not be inlined again.
r? @notriddle