Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/refactor: improve errors in case of ident with number at start #108854

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

Ezrashaw
Copy link
Contributor

@Ezrashaw Ezrashaw commented Mar 7, 2023

Improve parser code when we parse a integer (or float) literal but expect an identifier. We emit an error message saying that identifiers can't begin with numbers. This PR just improves that code and expands it to all identifiers. Note that I haven't implemented error recovery (this didn't exist before anyway), I might do that in a follow up PR.

@rustbot
Copy link
Collaborator

rustbot commented Mar 7, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 7, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Mar 8, 2023

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned wesleywiser Mar 8, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Mar 9, 2023

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 9, 2023

📌 Commit 252e0b3 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#106915 (Only load one CSS theme by default)
 - rust-lang#108294 (Place binder correctly for arbitrary trait bound suggestion)
 - rust-lang#108778 (x fmt: Don't print all modified files if there's more than 10)
 - rust-lang#108854 (feat/refactor: improve errors in case of ident with number at start)
 - rust-lang#108870 (Fix invalid inlining of reexport of reexport of private item)
 - rust-lang#108917 (Consider target_family as pal)
 - rust-lang#108922 (Add auto notification for changes to stable mir)
 - rust-lang#108929 (Fix typo in span_map.rs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bec7011 into rust-lang:master Mar 10, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 10, 2023
@Ezrashaw Ezrashaw deleted the improve-int-idents branch March 10, 2023 20:06
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 21, 2023
…=Nilstrieb

refactor/feat: refactor identifier parsing a bit

\+ error recovery for `expected_ident_found`

Prior art: rust-lang#108854
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 22, 2023
…=Nilstrieb

refactor/feat: refactor identifier parsing a bit

\+ error recovery for `expected_ident_found`

Prior art: rust-lang#108854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants