Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./configure should set profile = "user" by default #107050

Closed
jyn514 opened this issue Jan 18, 2023 · 9 comments · Fixed by #110541
Closed

./configure should set profile = "user" by default #107050

jyn514 opened this issue Jan 18, 2023 · 9 comments · Fixed by #110541
Assignees
@lionellloh
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Jan 18, 2023 •
edited by rustbot
Loading

This is part of https://jyn.dev/2023/01/12/Bootstrapping-Rust-in-2023.html that's not a breaking change. Setting profile = "user" will be useful regardless of the rest of the changes mentioned there, since it will let us change the global defaults in bootstrap without impacting distros as much.

This is blocked on #107049. Note that ./configure --set profile=x should override the default of user.

I would like to also set download-ci-rustc = false in src/bootstrap/defaults/config.user.toml at the same time.
@jyn514 jyn514 added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Jan 18, 2023
@reez12g
Copy link
Contributor

reez12g commented Jan 19, 2023

Is this an Issue that should be tackled after #107049 is completed?

@jyn514
Copy link
Member Author

jyn514 commented Jan 19, 2023

Yes, fixing this requires fixing the other first.

@reez12g
Copy link
Contributor

reez12g commented Jan 19, 2023

@rustbot claim

@zephaniahong zephaniahong mentioned this issue Feb 15, 2023
Closed
@lionellloh
Copy link
Contributor

@reez12g Hey Rento, are you still interested in working on this? I was working on issue 107049, and I think this is a natural extension of it. Would you might if I take over this issue? Otherwise, no pressure!

@zephaniahong zephaniahong mentioned this issue Feb 20, 2023
Merged
@reez12g
Copy link
Contributor

reez12g commented Feb 20, 2023

@lionellloh
I was still going to work on it, but if you can do it as a natural extension of your work, you are welcome to do it!

@lionellloh
Copy link
Contributor

@lionellloh I was still going to work on it, but if you can do it as a natural extension of your work, you are welcome to do it!

Cool, thanks for your understanding. I will put a PR after #108229 is merged in.

@rustbot claim

@rustbot rustbot assigned lionellloh and unassigned reez12g Feb 20, 2023
@jyn514
Copy link
Member Author

jyn514 commented Mar 1, 2023

#108229 has been merged :)

@jyn514 jyn514 removed the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Mar 1, 2023
@lionellloh
Copy link
Contributor

@jyn514

I would like to also set download-ci-rustc = false in src/bootstrap/defaults/config.user.toml at the same time.

Is download-ci-rustc under [build] or [llvm]

@jyn514
Copy link
Member Author

jyn514 commented Mar 2, 2023

@lionellloh I actually ended up making that change myself in #108625, sorry.

@jyn514 jyn514 mentioned this issue Mar 17, 2023
Closed
@jyn514 jyn514 mentioned this issue Apr 19, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Apr 19, 2023
@matthiaskrgr
Rollup merge of rust-lang#110541 - jyn514:fix-configure, r=ozkanonur
0820e31 
Fix various configure bugs

Fixes rust-lang#107050. Fixes rust-lang#108928. Closes rust-lang#108641.

I recommend reading this commit-by-commit to see the commit descriptions, but the code changes are small.

This also changes the README to suggest `configure` instead of `printf`, as well as a few other cleanups described in the commit message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lionellloh lionellloh

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix various configure bugs jyn514/rust
3 participants
@jyn514 @lionellloh @reez12g