-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler panic while compiling async_trait and adding "pub" as function modifier #107070
Comments
@rustbot label +I-ICE +T-compiler |
Can you post a reproducible example? I'm not able to get an ICE with the snippet here |
Sure, I was under the impression that the trait alone was causing it, it looks like it's more than just one thing. Attached the zip with minimal code needed to cause the issue. |
While the ICE happens in stable, there is no ICE on beta and nightly (although normal errors are still reported), so this has likely been fixed upstream |
With "regression" meaning no ICE: searched nightlies: from nightly-2022-10-29 to nightly-2022-12-10 bisected with cargo-bisect-rustc v0.6.5Host triple: x86_64-unknown-linux-gnu cargo bisect-rustc --access=github --start=1.66.1 --end=2022-12-10 --regress=non-ice -- build |
Well, it turns out it is #103827. cc @compiler-errors @wesleywiser |
@albertlarsan68 thanks for the heads up, though given that that PR fixed the issue rather than introduced the issue, I don't think the author and reviewer necessarily need pings 😝 |
It was to give heads up if this needs a test or it was the goal of the PR to fix this issue. |
@albertlarsan68 feel free to make a minimal test if you can -- I haven't looked at the zip file yet, does it depend on any nightly features? Probably fixed by the changes to |
Also, the ICE in the issue says:
@albertlarsan68 was this ICE reintroduced in a recent nightly? |
No, it is just that your PR is the one that fixed the ICE |
The following code fails to compile:
However, after observing start of the stacktrace I see the following message:
pub not permitted here because it's implied
,after removing it, this code compiles fine:
The depencencies used:
Here's the stacktrace:
The text was updated successfully, but these errors were encountered: