Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the usize field from CandidateSource::AliasBound #107380

Closed
lcnr opened this issue Jan 27, 2023 · 1 comment · Fixed by #107401
Closed

remove the usize field from CandidateSource::AliasBound #107380

lcnr opened this issue Jan 27, 2023 · 1 comment · Fixed by #107401
Assignees
@lenko-d
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-types Relevant to the types team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Comments

@lcnr
Copy link
Contributor

lcnr commented Jan 27, 2023 •
edited by rustbot
Loading

The field is currently unused and can be incorrect due to the way the new solver deals with projections

rust/compiler/rustc_trait_selection/src/solve/assembly.rs

Line 79 in 7919ef0

AliasBound(usize),

rust/compiler/rustc_trait_selection/src/solve/assembly.rs

Lines 220 to 221 in 7919ef0

// FIXME: This is broken if we care about the `usize` of `AliasBound` because the self type
// could be normalized to yet another projection with different item bounds.

@lcnr lcnr mentioned this issue Jan 27, 2023
Open
14 tasks
@lcnr lcnr added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-types Relevant to the types team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jan 27, 2023
@lcnr lcnr changed the title remove usize from the candidate source (corresponding fixme) remove the usize field from CandidateSource::AliasBound Jan 27, 2023
@lenko-d
Copy link
Contributor

lenko-d commented Jan 27, 2023

@rustbot claim

@lenko-d lenko-d mentioned this issue Jan 28, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 29, 2023
@matthiaskrgr
Rollup merge of rust-lang#107401 - lenko-d:remove_the_usize_field_fro…
70fc114 
…m_CandidateSource_AliasBound, r=compiler-errors

remove the usize field from CandidateSource::AliasBound

Fixes [rust-lang#107380](rust-lang#107380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenko-d lenko-d

Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-types Relevant to the types team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove the usize field from CandidateSource::AliasBound lenko-d/rust
2 participants
@lenko-d @lcnr