Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc-perf fails to build after #107956 #108258

Closed
KittyBorgX opened this issue Feb 20, 2023 · 4 comments
Closed

rustc-perf fails to build after #107956 #108258

KittyBorgX opened this issue Feb 20, 2023 · 4 comments
Labels
C-bug Category: This is a bug.

Comments

@KittyBorgX
Copy link
Member

KittyBorgX commented Feb 20, 2023

rustc-perf fails to build after #107956

It appears broken in https://perf.rust-lang.org/status.html

Error:

thread 'main' panicked at 'self.symlink_file(&rustfmt_path, &legacy_rustfmt) failed with File exists (os error 17)', download.rs:346:17
       note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Possible Workaround - Comment out

       #[cfg(not(windows))]
        {
            let legacy_rustfmt = self.initial_rustc.with_file_name(exe("rustfmt", host));
            if !legacy_rustfmt.exists() {
                t!(self.symlink_file(&rustfmt_path, &legacy_rustfmt));
            }
        }

in src/bootstrap/download.rs:342 to avoid symlinking rustfmt since are explicitly copying the rustfmt binary in #107956

zulip thread : https://rust-lang.zulipchat.com/#narrow/stream/247081-t compiler.2Fperformance/topic/Bootstrap.20benchmarking.20broken

cc : @jyn514 @Kobzol

@KittyBorgX KittyBorgX added the C-bug Category: This is a bug. label Feb 20, 2023
@KittyBorgX
Copy link
Member Author

KittyBorgX commented Feb 20, 2023

@rustbot claim
I want to fix this myself :)

@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2023

Error: Parsing assign command in comment failed: ...' claim' | error: expected end of command at >| ' -- I want'...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@KittyBorgX
Copy link
Member Author

As per zulip discussions, the pr will be reverted (for now)
I will release my assignment since there's nothing more that I can do.

@lqd
Copy link
Member

lqd commented Feb 22, 2023

This was fixed by #108302

@lqd lqd closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants