-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustdoc lists empty opaque type for async fn #109931
Comments
Not sure why I was preemptively pinged, but @GuillaumeGomez regressed this in #104889. searched nightlies: from nightly-2022-11-01 to nightly-2023-04-04 |
Anyways I can fix this since I already looked at the code. @rustbot claim |
I wasn't but it's great if you already have a solution. :) |
…be-documented, r=GuillaumeGomez Don't collect return-position impl traits for documentation rust-lang#104889 modified the rustdoc ast collection step to use a HIR visitor, which more thoroughly walks the HIR tree. that means that we're going to encounter inner items (incl return-position impl traits and async fn opaque futures) that are not possible to document. FIxes (but does not close due to being a beta regression) rust-lang#109931 r? `@GuillaumeGomez`
Is this fixed as of #109937, or are we waiting for the backport to beta? |
Let's keep this open until the beta backport happens. |
Done, not in a beta backport but the stable PR directly: #110413 . Thanks everyone! |
Since beta 1.69.0 (and also in nightly), the rustdoc output has an empty opaque type listed. Take this code:
Then save it as
main.rs
and do:There will be an empty opaque type listed, which is not clickable like the other things (probably due to being empty):
If you navigate to the
opaque..html
file manually, you get this:It also reproduces on current nightly as of filing this bug. And also for
cargo init --bin
followed by adding an async function and thencargo +beta doc
. The option to document private items is important.@rustbot modify labels: +regression-from-stable-to-beta -regression-untriaged +T-rustdoc
The text was updated successfully, but these errors were encountered: