Hide .o files in linker errors by default #109979
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
A-linkage
Area: linking into static, shared libraries and binaries
D-verbose
Diagnostics: Too much output caused by a single piece of incorrect code.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
jyn514
added
A-linkage
|
Note that the lack of line wrapping here is misleading; the original diagnostic was much harder to understand. |
|
It would be nice to keep an option to show the full commandline. I sometimes have copied the commandline to execute manually as part of debugging. |
|
I'd rather keep things as is, but if the output is shortened, then |
jyn514
added
the
D-verbose
This was referenced Dec 24, 2023
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this issue
Jan 26, 2024
show linker output even if the linker succeeds - show stderr by default - show stdout if `--verbose` is passed - remove both from RUSTC_LOG - hide the linker cli args unless `--verbose` is passed fixes rust-lang#83436. fixes rust-lang#38206. fixes rust-lang#109979. helps with rust-lang#46998. cc https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408986134 this is based on rust-lang#119129 for convenience so i didn't have to duplicate the changes around saving `--verbose` in rust-lang@cb6d033#diff-7a49efa20548d6806dbe1c66dd4dc445fda18fcbbf1709520cadecc4841aae12 r? `@bjorn3`
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 30, 2024
show linker output even if the linker succeeds - show stderr by default - show stdout if `--verbose` is passed - remove both from RUSTC_LOG - hide the linker cli args unless `--verbose` is passed fixes rust-lang#83436. fixes rust-lang#38206. fixes rust-lang#109979. helps with rust-lang#46998. cc https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408986134 this is based on rust-lang#119129 for convenience so i didn't have to duplicate the changes around saving `--verbose` in rust-lang@cb6d033#diff-7a49efa20548d6806dbe1c66dd4dc445fda18fcbbf1709520cadecc4841aae12 r? `@bjorn3`
|
On Mach-O linkers, this could also be solved with the use of the Unsure if other linkers have something similar, but it sounds probable that there would be some way to specify the files to link other than all of them via. the program arguments? |
|
Related: #52699 |
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this issue
Sep 11, 2024
show linker output even if the linker succeeds - show stderr by default - show stdout if `--verbose` is passed - remove both from RUSTC_LOG - hide the linker cli args unless `--verbose` is passed fixes rust-lang#83436. fixes rust-lang#38206. fixes rust-lang#109979. helps with rust-lang#46998. cc https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408986134 this is based on rust-lang#119129 for convenience so i didn't have to duplicate the changes around saving `--verbose` in rust-lang@cb6d033#diff-7a49efa20548d6806dbe1c66dd4dc445fda18fcbbf1709520cadecc4841aae12 r? `@bjorn3`
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Sep 11, 2024
show linker output even if the linker succeeds - show stderr by default - show stdout if `--verbose` is passed - remove both from RUSTC_LOG - hide the linker cli args unless `--verbose` is passed fixes rust-lang#83436. fixes rust-lang#38206. fixes rust-lang#109979. helps with rust-lang#46998. cc https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408986134 this is based on rust-lang#119129 for convenience so i didn't have to duplicate the changes around saving `--verbose` in rust-lang@cb6d033#diff-7a49efa20548d6806dbe1c66dd4dc445fda18fcbbf1709520cadecc4841aae12 r? `@bjorn3`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code
Current output
Desired output
Rationale and extra context
Showing so many .o files is overwhelming and unhelpful. In the vast majority of cases, the exact object files and directories don't matter and showing the options passed to the linker is enough. It would be nice to hide them by default and only show them if the user explicitly opts-in.
Other cases
No response
Anything else?
HEAD is branched from 90a9f69.
The text was updated successfully, but these errors were encountered: