Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs rust-mode.el: "file:line-num" output does not work with "note:" #11128

Closed
pnkfelix opened this issue Dec 23, 2013 · 3 comments
Closed

emacs rust-mode.el: "file:line-num" output does not work with "note:" #11128

pnkfelix opened this issue Dec 23, 2013 · 3 comments

Comments

@pnkfelix
Copy link
Member

The problem described in #6887 is afflicting rustc's "note:" output, probably because the regexp added in 521fb04 only has cases for "error:" and "warning:", not "note:".

@pnkfelix
Copy link
Member Author

part of #8793

@huonw
Copy link
Member

huonw commented Aug 11, 2014

This may be fixed, at least, the following set-up allows me to jump to the right place from inside the compilation mode:

// Cargo.toml
[project]
name = "11128"
version = "0.0.0"
authors = []

[dependencies.compile_msg]
git = "https://github.com/huonw/compile_msg"
// src/main.rs
#![feature(phase)]

#[phase(plugin)] extern crate compile_msg;

fn main() {
    compile_note!("hello");
}

cargo build prints

/home/huon/projects/test-rust/triage/11128/src/main.rs:6:5: 6:28 note: hello
/home/huon/projects/test-rust/triage/11128/src/main.rs:6     compile_note!("hello");
                                                             ^~~~~~~~~~~~~~~~~~~~~~~

and I can jump to exactly that line by pressing enter while hovering over it.

This may not be an exact reproduction of the issues here, which I why I'm not closing it. Opinion, @pnkfelix?

@steveklabnik
Copy link
Member

Moved to rust-lang/rust-mode#7

flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 14, 2023
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 14, 2023
[significant_drop_tightening] Fix rust-lang#11128

Fix rust-lang#11128

```
changelog: [`significant_drop_tightening`]: Consider manual alias of the `drop` function.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants