You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It doesn't make sense that adding #[doc(hidden)] to a private function makes it's block visible, or that running --document-hidden-items makes a block with only private functions visible. I'm not sure what the exact behavior should be here
The text was updated successfully, but these errors were encountered:
Impl blocks can be skipped if they are: empty; not a trait impl; and have no
documentation.
There is one special case: if the impl block contains only private items.
The logic makes sense to me: impl blocks with only private items should very likely not be visible to readers. The question here I think should be more "should we do the same with impls containing only hidden items?". What do you think?
Since #90905, rustdoc has impl blocks with docs but no items: But it's logic doesn't make (user facing) sense
Running this code across various flag's gets us:
--document-private-items
--document-hidden-items
--document-private-items --document-hidden-items
It doesn't make sense that adding
#[doc(hidden)]
to a private function makes it's block visible, or that running--document-hidden-items
makes a block with only private functions visible. I'm not sure what the exact behavior should be hereThe text was updated successfully, but these errors were encountered: