Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io::fs::test::truncate_works::native is flaky on windows #11638

Closed
alexcrichton opened this issue Jan 18, 2014 · 1 comment
Closed

io::fs::test::truncate_works::native is flaky on windows #11638

alexcrichton opened this issue Jan 18, 2014 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows

Comments

@alexcrichton
Copy link
Member

http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2740/steps/test/logs/stdio

Not sure why...
@huonw
Copy link
Member

huonw commented Jun 16, 2014

triage: seems to be working, closing. (I discussed with @alexcrichton on IRC.)

@huonw huonw closed this as completed Jun 16, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14442 - DropDemBits:structured-snippet-api, r…
da9c0bd 
…=Veykril

internal: Implement Structured API for snippets

Fixes rust-lang#11638 (including moving the cursor before the generated type parameter)

Adds `add_tabstop_{before,after}` for inserting tabstop snippets before & after nodes, and `add_placeholder_snippet` for wrapping nodes inside placeholder nodes.

Currently, the snippets are inserted into the syntax tree in `SourceChange::commit` so that snippet bits won't interfere with syntax lookups before completing a `SourceChange`.

It would be preferable if snippet rendering was deferred to after so that rendering can work directly with text ranges, but have left that for a future PR (it would also make it easier to finely specify which text edits have snippets in them).

Another possible snippet variation to support would be a group of placeholders (i.e. placeholders with the same tabstop number) so that a generated item and its uses can be renamed right as it's generated, which is something that is technically supported by the current snippet hack in VSCode, though it's not clear if that's a thing that is officially supported.
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 21, 2023
@bors
Auto merge of rust-lang#11638 - samueltardieu:into-iter, r=Manishearth
33f49f3 
Fix two typos in lint description

Fix rust-lang#11636

changelog: none
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Feb 11, 2024
@bors
Auto merge of rust-lang#16467 - DropDemBits:structured-snippet-migrat…
57fda12 
…e-6, r=DropDemBits

internal: Migrate assists to the structured snippet API, part 6/7

Continuing from rust-lang#16082

Migrates the following assists:

- `extract_function`
- `generate_getter_or_setter`
- `generate_impl`
- `generate_new`
- `replace_derive_with_manual_impl`

Would've been the final PR in the structured snippet migration series, but I didn't notice that `generate_trait_from_impl` started to use `{insert,replace}_snippet` when I first started the migration 😅. This appears to be a pretty self-contained change, so I'll leave that for a separate future PR.

This also removes the last usages of `render_snippet`, which was a follow up goal of rust-lang#11638. 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @huonw