Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--verbose should imply -Z write-long-types-to-disk=no #119130

Closed
jyn514 opened this issue Dec 19, 2023 · 7 comments · Fixed by #121328
Closed

--verbose should imply -Z write-long-types-to-disk=no #119130

jyn514 opened this issue Dec 19, 2023 · 7 comments · Fixed by #121328
Assignees
@ffmancera
Labels
A-diagnostics Area: Messages for errors, warnings, and lints D-papercut Diagnostics: An error or lint that needs small tweaks. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Dec 19, 2023 •
edited by rustbot
Loading

see https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706, #119129

--verbose should imply -Z write-long-types-to-disk=no. the code in ty_string_with_limit should take --verbose into account (apparently this affects Ty::sort_string, i'm not familiar with this code). writing a file to disk should suggest passing --verbose.

cc @estebank

@rustbot label A-diagnostics
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-diagnostics Area: Messages for errors, warnings, and lints labels Dec 19, 2023
@estebank estebank added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. D-papercut Diagnostics: An error or lint that needs small tweaks. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 19, 2023
@yossydev
Copy link

@rustbot claim

@Rajveer100
Copy link
Contributor

@rustbot claim

@rustbot rustbot assigned Rajveer100 and unassigned yossydev Dec 21, 2023
@Rajveer100
Copy link
Contributor

@yossydev
I hadn't refreshed the page so I didn't notice you had already claimed the issue, feel free to open a PR if you have a fix.

@yossydev
Copy link

@rustbot claim

@rustbot rustbot assigned yossydev and unassigned Rajveer100 Dec 21, 2023
@jyn514
Copy link
Member Author

jyn514 commented Dec 25, 2023

note this will be annoying to work on until #119129 lands since currently --verbose isn't stored anywhere, only used directly in rustc_driver_impl

@estebank
Copy link
Contributor

And it has now landed in main.

@ffmancera
Copy link
Contributor

I have a patch ready that I think it might be a good candidate. I am taking the issue. @yossydev if this is a problem and you also have something ready I can drop it, is fine.

@rustbot claim

@rustbot rustbot assigned ffmancera and unassigned yossydev Feb 17, 2024
@ffmancera ffmancera mentioned this issue Feb 20, 2024
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Feb 21, 2024
@Dylan-DPC
Rollup merge of rust-lang#121328 - ffmancera:ff/verbose_long_type, r=…
4a205bb 
…compiler-errors

Make --verbose imply -Z write-long-types-to-disk=no

When shortening the type it is necessary to take into account the `--verbose` flag, if it is activated, we must always show the entire type and not write it in a file.

Fixes: rust-lang#119130
@bors bors closed this as completed in e54ef0a Feb 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 21, 2024
@rust-timer
Unrolled build for rust-lang#121328
09c8958 
Rollup merge of rust-lang#121328 - ffmancera:ff/verbose_long_type, r=compiler-errors

Make --verbose imply -Z write-long-types-to-disk=no

When shortening the type it is necessary to take into account the `--verbose` flag, if it is activated, we must always show the entire type and not write it in a file.

Fixes: rust-lang#119130
@sandersaares sandersaares mentioned this issue May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffmancera ffmancera

Labels
A-diagnostics Area: Messages for errors, warnings, and lints D-papercut Diagnostics: An error or lint that needs small tweaks. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make --verbose imply -Z write-long-types-to-disk=no ffmancera/rust
6 participants
@estebank @jyn514 @ffmancera @Rajveer100 @rustbot @yossydev