Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop generating a TyDesc for trait objects #11919

Closed
thestinger opened this issue Jan 30, 2014 · 1 comment
Closed

stop generating a TyDesc for trait objects #11919

thestinger opened this issue Jan 30, 2014 · 1 comment
Labels
I-compiletime Issue: Problems and improvements with respect to compile times.

Comments

@thestinger
Copy link
Contributor

With #11909, it only generates it to grab the destructor from it. This will involve a refactoring of the glue code. It may be a good idea to wait until procs and managed pointers are no longer using a TyDesc.
@thestinger thestinger mentioned this issue Jan 30, 2014
Merged
@thestinger
Copy link
Contributor Author

Fixed by eced501

flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 8, 2024
@bors
Auto merge of rust-lang#11919 - y21:manual_c_str_literals, r=xFrednet
005b6c2 
new lint: `manual_c_str_literals`

With rust-lang#117472 merged and `c""` syntax stabilized, I think it'd be nice to have a lint for using `CStr::from_ptr` (and similar constructors) with a string literal as an argument.
We can probably also lint `"foo\0".as_ptr()` and suggest `c"foo".as_ptr()`. I might add that to this PR tomorrow if I find the time.

The byte string literal to c string literal rewriting is ugly but oh well.

changelog: new lint: `manual_c_str_literals`
[rust-lang#11919](rust-lang/rust-clippy#11919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-compiletime Issue: Problems and improvements with respect to compile times.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thestinger