Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc UI: "This example is not tested" popup is below sidebar #119472

Closed
lukas-code opened this issue Dec 31, 2023 · 1 comment
Closed

rustdoc UI: "This example is not tested" popup is below sidebar #119472

lukas-code opened this issue Dec 31, 2023 · 1 comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@lukas-code
Copy link
Member

For example here:

image

How it used look:

image

Meta

Happens on current nightly and beta (1.76).

@rustbot label T-rustdoc A-rustdoc-ui regression-from-stable-to-beta
@lukas-code lukas-code added the C-bug Category: This is a bug. label Dec 31, 2023
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-rustdoc-ui Area: Rustdoc UI (generated HTML) regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Dec 31, 2023
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 31, 2023
@lukas-code lukas-code mentioned this issue Dec 31, 2023
Merged
fmease added a commit to fmease/rust that referenced this issue Jan 2, 2024
@fmease
Rollup merge of rust-lang#119477 - lukas-code:tooltip-z-index, r=notr…
a9eaa02 
…iddle

rustdoc ui: adjust tooltip z-index to be above sidebar

In rust-lang#115660 the sidebar's z-index was changed to 100. This PR changes the tooltip's z-index to 101 to be above the sidebar again.

Fixes [after beta-backport] rust-lang#119472.
fmease added a commit to fmease/rust that referenced this issue Jan 3, 2024
@fmease
Rollup merge of rust-lang#119477 - lukas-code:tooltip-z-index, r=notr…
eeafb86 
…iddle

rustdoc ui: adjust tooltip z-index to be above sidebar

In rust-lang#115660 the sidebar's z-index was changed to 100. This PR changes the tooltip's z-index to 101 to be above the sidebar again.

Fixes [after beta-backport] rust-lang#119472.
fmease added a commit to fmease/rust that referenced this issue Jan 3, 2024
@fmease
Rollup merge of rust-lang#119477 - lukas-code:tooltip-z-index, r=notr…
493792b 
…iddle

rustdoc ui: adjust tooltip z-index to be above sidebar

In rust-lang#115660 the sidebar's z-index was changed to 100. This PR changes the tooltip's z-index to 101 to be above the sidebar again.

Fixes [after beta-backport] rust-lang#119472.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 3, 2024
@rust-timer
Unrolled build for rust-lang#119477
6fd7f0d 
Rollup merge of rust-lang#119477 - lukas-code:tooltip-z-index, r=notriddle

rustdoc ui: adjust tooltip z-index to be above sidebar

In rust-lang#115660 the sidebar's z-index was changed to 100. This PR changes the tooltip's z-index to 101 to be above the sidebar again.

Fixes [after beta-backport] rust-lang#119472.
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 4, 2024
@lukas-code lukas-code mentioned this issue Jan 8, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 11, 2024
@bors
Auto merge of rust-lang#119743 - lukas-code:beta-z-index, r=notriddle
7bcd95c 
[beta] rustdoc ui: adjust tooltip z-index to be above sidebar

Backport of rust-lang#119477.
Fixes rust-lang#119472.

range-diff:
```range-diff
446:  d796ad4 =  11:  53637cd rustdoc ui: adjust tooltip z-index to be above sidebar
459:  b1853eb !  12:  c4c4ff6 use css variable for z-index of the sidebar
    `@@` src/librustdoc/html/static/css/rustdoc.css: so that we can apply CSS-filters to
        margin-top: 7px;
        border-radius: 3px;
        border: 1px solid var(--border-color);
    -`@@` src/librustdoc/html/static/css/rustdoc.css: a.tooltip:hover::after {
    - }
    - .src #sidebar-button {
    -   left: 8px;
    --  z-index: 101;
    -+  z-index: calc(var(--desktop-sidebar-z-index) + 1);
    - }
    - .hide-sidebar .src #sidebar-button {
    -   position: static;
```

The "show sidebar" button on the [source view page](https://doc.rust-lang.org/nightly/src/std/lib.rs.html) works differently on beta and nightly, but it is in fact above the sidebar in both versions.

beta button:
![beta button](https://github.com/rust-lang/rust/assets/26522220/24d7e86f-d19e-452f-bef2-6b6004b42255)

nightly button:
![nightly button](https://github.com/rust-lang/rust/assets/26522220/239dfdda-d9ca-4945-94dd-96254ed1c13f)

cc `@Mark-Simulacrum`
@fmease
Copy link
Member

fmease commented Jan 11, 2024

Fixed in #119477.
Backported in #119743.
Closing as completed.

@fmease fmease closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@apiraino @saethlin @fmease @lukas-code @rustbot