Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x clippy --fix should allow for --allow-dirty, --allow-staged to be passed #119483

Closed
Noratrieb opened this issue Jan 1, 2024 · 0 comments · Fixed by #119486
Closed

x clippy --fix should allow for --allow-dirty, --allow-staged to be passed #119483

Noratrieb opened this issue Jan 1, 2024 · 0 comments · Fixed by #119486
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Noratrieb
Copy link
Member

Without those, cargo fix refuses to do anything if something is dirty. It is very hard to pass these flags via bootstrap, bootstrap should just expose them as flags on x clippy.
@Noratrieb Noratrieb added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Jan 1, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 1, 2024
@Noratrieb Noratrieb removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 1, 2024
@onur-ozkan onur-ozkan mentioned this issue Jan 1, 2024
Merged
@bors bors closed this as completed in 94bfc28 Jan 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 6, 2024
@rust-timer
Unrolled build for rust-lang#119486
2d0c651 
Rollup merge of rust-lang#119486 - onur-ozkan:clippy-allow-dirty-and-staged, r=Mark-Simulacrum

pass allow-{dirty,staged} to clippy

Support of Clippy's `--allow-dirty` and `--allow-staged` flags on bootstrap.

Resolves rust-lang#119483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pass allow-{dirty,staged} to clippy onur-ozkan/rust
2 participants
@rustbot @Noratrieb