LLVM 18: tests/assembly/targets/targets-elf.rs fails

[durin42]

Right now I have to run with #116672 applied, but when I do several tests fail, eg:

tests/assembly/targets/targets-elf.rs#aarch64_unknown_illumos:

---- [assembly] tests/assembly/targets/targets-elf.rs#aarch64_unknown_illumos stdout ----

error in revision `aarch64_unknown_illumos`: verification with 'FileCheck' failed
status: exit status: 1
command: "/usr/local/google/home/augie/Programming/big/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--input-file" "/usr/local/google/home/augie/Programming/big/rust/build/x86_64-unknown-linux-gnu/test/assembly/targets/targets-elf.aarch64_unknown_illumos/targets-elf.s" "/usr/local/google/home/augie/Programming/big/rust/tests/assembly/targets/targets-elf.rs" "--allow-unused-prefixes" "--check-prefixes" "CHECK,NONMSVC,aarch64_unknown_illumos" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
/usr/local/google/home/augie/Programming/big/rust/tests/assembly/targets/targets-elf.rs:633:11: error: CHECK: expected string not found in input
// CHECK: .section
          ^
/usr/local/google/home/augie/Programming/big/rust/build/x86_64-unknown-linux-gnu/test/assembly/targets/targets-elf.aarch64_unknown_illumos/targets-elf.s:1:1: note: scanning from here
 .text
^
/usr/local/google/home/augie/Programming/big/rust/build/x86_64-unknown-linux-gnu/test/assembly/targets/targets-elf.aarch64_unknown_illumos/targets-elf.s:1:2: note: possible intended match here
 .text
 ^

Input file: /usr/local/google/home/augie/Programming/big/rust/build/x86_64-unknown-linux-gnu/test/assembly/targets/targets-elf.aarch64_unknown_illumos/targets-elf.s
Check file: /usr/local/google/home/augie/Programming/big/rust/tests/assembly/targets/targets-elf.rs

-dump-input=help explains the following input dump.

Input was:
<<<<<<
             1:  .text
check:633'0     X~~~~~~ error: no match found
check:633'1      ?      possible intended match
             2:  .file "targets_elf.d90b8376a746b330-cgu.0"
check:633'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             3:  .ident "rustc version 1.77.0-dev"
check:633'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>>>
------------------------------------------

more are visible in our CI for LLVM/Rust HEAD

[nikic]

I think this test should check for .text instead of .section.

I believe that currently this test is actually matching something like .section ".note.GNU-stack","",@progbits, which is not emitted on Solaris since llvm/llvm-project@6ef767c.

I assume the intention was to look for .section .text, but that's one of the section types for which an explicit .section is normally omitted.

[nikic]

Okay, just looking for .text doesn't work, because apparently targets-elf, despite the name, currently also includes the MachO targets.