-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest name value cfg when only value is used for check-cfg #120427
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
D-terse
Diagnostics: An error or lint that doesn't give enough information about the problem at hand.
F-check-cfg
--check-cfg
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
Noratrieb
added
A-diagnostics
Area: Messages for errors, warnings, and lints
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
D-terse
Diagnostics: An error or lint that doesn't give enough information about the problem at hand.
F-check-cfg
--check-cfg
labels
Jan 27, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Jan 30, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? `@Nilstrieb`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jan 30, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? ``@Nilstrieb``
Nadrieril
added a commit
to Nadrieril/rust
that referenced
this issue
Jan 31, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? ```@Nilstrieb```
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 3, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? ````@Nilstrieb````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 3, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? `````@Nilstrieb`````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 5, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? ``````@Nilstrieb``````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 5, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? ```````@Nilstrieb```````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 5, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? ````````@Nilstrieb````````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 5, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? `````````@Nilstrieb`````````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 5, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? ``````````@Nilstrieb``````````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 6, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? ```````````@Nilstrieb```````````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 6, 2024
…ame, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? ````````````@Nilstrieb````````````
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Feb 7, 2024
Rollup merge of rust-lang#120435 - chenyukang:yukang-fix-120427-cfg-name, r=Urgau,Nilstrieb Suggest name value cfg when only value is used for check-cfg Fixes rust-lang#120427 r? `````````````@Nilstrieb`````````````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
D-terse
Diagnostics: An error or lint that doesn't give enough information about the problem at hand.
F-check-cfg
--check-cfg
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Code
Current output
Desired output
= help: try `cfg(target_os = "linux")`
Rationale and extra context
The user wanted something with "linux", and there is a name-value cfg that has the value "linux", so they probably wanted that.
Other cases
Rust Version
Anything else?
No response
The text was updated successfully, but these errors were encountered: