Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Android platform images to a more recent version #120567

Closed
tmandry opened this issue Feb 2, 2024 · 1 comment
Closed

Upgrade Android platform images to a more recent version #120567

tmandry opened this issue Feb 2, 2024 · 1 comment
Assignees
@rustbot
Labels
A-CI Area: Our Github Actions CI C-cleanup Category: PRs that clean code up or issues documenting cleanup. O-android Operating system: Android T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@tmandry
Copy link
Member

tmandry commented Feb 2, 2024 •
edited by rustbot
Loading

Currently Rust CI uses an Android platform image with API level 18, which was released more than 10 years ago in 2013.

I first realized this when working on #120326 and noticing that aborts resulted in SIGSEGV, which libc used to do on Android up until sometime in 2013.

From talking with @maurer it sounds like the right thing to do is to upgrade the platform image to one with ABI level 25, now that it's the min supported NDK target.

This issue has been assigned to @maurer via this comment.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 2, 2024
@tmandry tmandry added O-android Operating system: Android T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. A-CI Area: Our Github Actions CI C-cleanup Category: PRs that clean code up or issues documenting cleanup. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 2, 2024
@tmandry
Copy link
Member Author

tmandry commented Feb 2, 2024

@rustbot assign @maurer

@rustbot rustbot self-assigned this Feb 2, 2024
tmandry added a commit to tmandry/rust that referenced this issue Feb 2, 2024
@tmandry
Ignore test-panic-abort tests on Android
614cecd 
Until rust-lang#120567 is fixed.
tmandry added a commit to tmandry/rust that referenced this issue Feb 2, 2024
@tmandry
Ignore test-panic-abort tests on Android
48f664b 
Until rust-lang#120567 is fixed.
@tmandry tmandry mentioned this issue Feb 2, 2024
Merged
maurer added a commit to maurer/rust that referenced this issue Feb 2, 2024
@maurer
Update Android testing to API 21, matching NDK 26
46bd270 
We were running testing on API 18, which was already out of support for
NDK 25, and some of the ancient behavior in that image was causing
trouble when developing `rustc` features (rust-lang#120326).

We'll be updating to NDK 26 (latest LTS) shortly, so rather than
updating to API 19, then again to API 21 in a bit, just jump straight
to 21.

Fixes: rust-lang#120567
maurer added a commit to maurer/rust that referenced this issue Mar 24, 2024
@maurer
Update Android testing to API 21, matching NDK 26
93acd1b 
We were running testing on API 18, which was already out of support for
NDK 25, and some of the ancient behavior in that image was causing
trouble when developing `rustc` features (rust-lang#120326).

We'll be updating to NDK 26 (latest LTS) shortly, so rather than
updating to API 19, then again to API 21 in a bit, just jump straight
to 21.

Fixes: rust-lang#120567
maurer added a commit to maurer/rust that referenced this issue May 7, 2024
@maurer
Update Android testing to API 21, matching NDK 26
bf3ceab 
We were running testing on API 18, which was already out of support for
NDK 25, and some of the ancient behavior in that image was causing
trouble when developing `rustc` features (rust-lang#120326).

Update to the current LTS NDK 26, and to its minimum supported API 21.

Fixes: rust-lang#120567
maurer added a commit to maurer/rust that referenced this issue May 18, 2024
@maurer
Update Android testing to API 21, matching NDK 26
ad0504b 
We were running testing on API 18, which was already out of support for
NDK 25, and some of the ancient behavior in that image was causing
trouble when developing `rustc` features (rust-lang#120326).

Update to the current LTS NDK 26, and to its minimum supported API 21.

Fixes: rust-lang#120567
maurer added a commit to maurer/rust that referenced this issue Jul 10, 2024
@maurer
Update Android testing to API 21, matching NDK 26
cb5db1a 
We were running testing on API 18, which was already out of support for
NDK 25, and some of the ancient behavior in that image was causing
trouble when developing `rustc` features (rust-lang#120326).

Update to the current LTS NDK 26, and to its minimum supported API 21.

Fixes: rust-lang#120567
maurer added a commit to maurer/rust that referenced this issue Jul 18, 2024
@maurer
Update Android testing to API 21, matching NDK 26
2521575 
We were running testing on API 18, which was already out of support for
NDK 25, and some of the ancient behavior in that image was causing
trouble when developing `rustc` features (rust-lang#120326).

Update to the current LTS NDK 26, and to its minimum supported API 21.

Fixes: rust-lang#120567
maurer added a commit to maurer/rust that referenced this issue Jul 19, 2024
@maurer
Update Android testing to API 21, matching NDK 26
a1e538c 
We were running testing on API 18, which was already out of support for
NDK 25, and some of the ancient behavior in that image was causing
trouble when developing `rustc` features (rust-lang#120326).

Update to the current LTS NDK 26, and to its minimum supported API 21.

Fixes: rust-lang#120567
maurer added a commit to maurer/rust that referenced this issue Jul 25, 2024
@maurer
Update Android testing to API 21, matching NDK 26
a0c5959 
We were running testing on API 18, which was already out of support for
NDK 25, and some of the ancient behavior in that image was causing
trouble when developing `rustc` features (rust-lang#120326).

Update to the current LTS NDK 26, and to its minimum supported API 21.

Fixes: rust-lang#120567
@bors bors closed this as completed in 8bf9aea Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
A-CI Area: Our Github Actions CI C-cleanup Category: PRs that clean code up or issues documenting cleanup. O-android Operating system: Android T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmandry @rustbot