-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unused_qualifications clashes with unused_import #121331
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
F-coroutines
`#![feature(coroutines)]`
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
matthiaskrgr
added
A-diagnostics
Area: Messages for errors, warnings, and lints
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
F-coroutines
`#![feature(coroutines)]`
labels
Feb 20, 2024
matthiaskrgr
changed the title
false positive: unused_qualifications
unused_qualifications clashes with unused_import
Feb 20, 2024
@rustbot claim |
surechen
added a commit
to surechen/rust
that referenced
this issue
Mar 11, 2024
surechen
added a commit
to surechen/rust
that referenced
this issue
Mar 12, 2024
surechen
added a commit
to surechen/rust
that referenced
this issue
Mar 12, 2024
surechen
added a commit
to surechen/rust
that referenced
this issue
Mar 12, 2024
surechen
added a commit
to surechen/rust
that referenced
this issue
Mar 13, 2024
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Mar 14, 2024
Fix the conflict problem between the diagnostics fixes of lint `unnecessary_qualification` and `unused_imports` fixes rust-lang#121331 For an `item` that triggers lint unnecessary_qualification, if the `use item` which imports this item is also trigger unused import, fixing the two lints at the same time may lead to the problem that the `item` cannot be found. This PR will avoid reporting lint unnecessary_qualification when conflict occurs. r? `@petrochenkov`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Mar 14, 2024
Fix the conflict problem between the diagnostics fixes of lint `unnecessary_qualification` and `unused_imports` fixes rust-lang#121331 For an `item` that triggers lint unnecessary_qualification, if the `use item` which imports this item is also trigger unused import, fixing the two lints at the same time may lead to the problem that the `item` cannot be found. This PR will avoid reporting lint unnecessary_qualification when conflict occurs. r? ``@petrochenkov``
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Mar 15, 2024
Rollup merge of rust-lang#122373 - surechen:fix_121331, r=petrochenkov Fix the conflict problem between the diagnostics fixes of lint `unnecessary_qualification` and `unused_imports` fixes rust-lang#121331 For an `item` that triggers lint unnecessary_qualification, if the `use item` which imports this item is also trigger unused import, fixing the two lints at the same time may lead to the problem that the `item` cannot be found. This PR will avoid reporting lint unnecessary_qualification when conflict occurs. r? ``@petrochenkov``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
F-coroutines
`#![feature(coroutines)]`
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Code
Current output
Desired output
No response
Rationale and extra context
The suggestion fails to apply with cargo fix
The text was updated successfully, but these errors were encountered: