Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the Node.js version to 20 #123965

Closed
DianQK opened this issue Apr 15, 2024 · 0 comments · Fixed by #123981
Closed

Upgrade the Node.js version to 20 #123965

DianQK opened this issue Apr 15, 2024 · 0 comments · Fixed by #123981
Labels
A-CI Area: Our Github Actions CI T-docs-rs Relevant to the docs-rs subteam, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@DianQK
Copy link
Member

DianQK commented Apr 15, 2024

I noticed that we are using version v16.9.0 in mingw-check, which is no longer supported. I even found that we are using v14.20.0 on x86_64-gnu-tools. Here's more information: https://nodejs.org/en/about/previous-releases and https://endoflife.date/nodejs.

@rustbot label +T-infra +A-ci +T-docs-rs
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-CI Area: Our Github Actions CI T-docs-rs Relevant to the docs-rs subteam, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 15, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 15, 2024
@Kobzol Kobzol mentioned this issue Apr 15, 2024
Merged
@bors bors closed this as completed in 426a698 Apr 21, 2024
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Apr 23, 2024
@bors
Auto merge of #123981 - Kobzol:update-nodejs, r=Mark-Simulacrum
bc23d07 
CI: add script for installing NodeJS and update it to v20

I centralized the installation on a single place to make it simple to update the NodeJS version across the board.

Fixes: rust-lang/rust#123965

r? `@Mark-Simulacrum`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@bors
Auto merge of #123981 - Kobzol:update-nodejs, r=Mark-Simulacrum
228e46d 
CI: add script for installing NodeJS and update it to v20

I centralized the installation on a single place to make it simple to update the NodeJS version across the board.

Fixes: rust-lang/rust#123965

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-CI Area: Our Github Actions CI T-docs-rs Relevant to the docs-rs subteam, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: add script for installing NodeJS and update it to v20 Kobzol/rust
3 participants
@DianQK @jieyouxu @rustbot