Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for "vectorcall" ABI #124485

Open
1 of 4 tasks
beetrees opened this issue Apr 28, 2024 · 1 comment
Open
1 of 4 tasks

Tracking Issue for "vectorcall" ABI #124485

beetrees opened this issue Apr 28, 2024 · 1 comment
Labels
A-ABI Area: Concerning the application binary interface (ABI) C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC O-windows Operating system: Windows T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@beetrees
Copy link
Contributor

beetrees commented Apr 28, 2024

This is a tracking issue for the "vectorcall" and "vectorcall-unwind" ABIs.
The feature gate for the issue is #![feature(abi_vectorcall)].

(Note that this feature was added in 2015, but didn't have a tracking issue until now.)

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Discussion comments will get marked as off-topic or deleted.
Repeated discussions on the tracking issue may lead to the tracking issue getting locked.

Steps

Unresolved Questions

Currently an LLVM error is emitted if there is an attempt to use the ABI on a target without the required target features (e.g. i586), but only if the specific usage of the ABI would require use of the disabled registers (e.g. on i586 targets extern "vectorcall" fn f() -> i64 { ... } will compile fine but extern "vectorcall" fn f() -> f64 { ... } will cause an LLVM error). Should the compiler always error if the ABI is used and SSE2 is disabled? According to https://learn.microsoft.com/en-us/cpp/cpp/vectorcall the ABI is only supported when SSE2 is enabled. Closely related to #116558.

Implementation history

"vectorcall" added in #30567.
"vectorcall-unwind" added in #93561.

@beetrees beetrees added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Apr 28, 2024
@beetrees
Copy link
Contributor Author

@rustbot label +A-abi +O-windows +T-lang

@rustbot rustbot added A-ABI Area: Concerning the application binary interface (ABI) O-windows Operating system: Windows T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Apr 28, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jun 3, 2024
…, r=ehuss

Add tracking issue and unstable book page for `"vectorcall"` ABI

Originally added in 2015 by rust-lang#30567, the Windows `"vectorcall"` ABI didn't have a tracking issue until now.

Tracking issue: rust-lang#124485
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jun 3, 2024
…, r=ehuss

Add tracking issue and unstable book page for `"vectorcall"` ABI

Originally added in 2015 by rust-lang#30567, the Windows `"vectorcall"` ABI didn't have a tracking issue until now.

Tracking issue: rust-lang#124485
Noratrieb added a commit to Noratrieb/rust that referenced this issue Jun 4, 2024
…, r=ehuss

Add tracking issue and unstable book page for `"vectorcall"` ABI

Originally added in 2015 by rust-lang#30567, the Windows `"vectorcall"` ABI didn't have a tracking issue until now.

Tracking issue: rust-lang#124485
Noratrieb added a commit to Noratrieb/rust that referenced this issue Jun 4, 2024
…, r=ehuss

Add tracking issue and unstable book page for `"vectorcall"` ABI

Originally added in 2015 by rust-lang#30567, the Windows `"vectorcall"` ABI didn't have a tracking issue until now.

Tracking issue: rust-lang#124485
jieyouxu added a commit to jieyouxu/rust that referenced this issue Jun 4, 2024
…, r=ehuss

Add tracking issue and unstable book page for `"vectorcall"` ABI

Originally added in 2015 by rust-lang#30567, the Windows `"vectorcall"` ABI didn't have a tracking issue until now.

Tracking issue: rust-lang#124485
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jun 4, 2024
Rollup merge of rust-lang#124486 - beetrees:vectorcall-tracking-issue, r=ehuss

Add tracking issue and unstable book page for `"vectorcall"` ABI

Originally added in 2015 by rust-lang#30567, the Windows `"vectorcall"` ABI didn't have a tracking issue until now.

Tracking issue: rust-lang#124485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ABI Area: Concerning the application binary interface (ABI) C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC O-windows Operating system: Windows T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants