Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc for std contains broken links in the implementors sections #124635

Closed
valaphee opened this issue May 2, 2024 · 12 comments · Fixed by #124864
Closed

Doc for std contains broken links in the implementors sections #124635

valaphee opened this issue May 2, 2024 · 12 comments · Fixed by #124864
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@valaphee
Copy link

valaphee commented May 2, 2024

https://doc.rust-lang.org/std/clone/trait.Clone.html for example lists implementations of Clone in gimli, which aren't visible anyway and the links are also broken.
@valaphee valaphee added the C-bug Category: This is a bug. label May 2, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 2, 2024
@workingjubilee
Copy link
Member

Not present in the docs for 1.77.2, regression?

@workingjubilee workingjubilee added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. labels May 2, 2024
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 2, 2024
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 3, 2024
@ehuss ehuss mentioned this issue May 7, 2024
Closed
@workingjubilee
Copy link
Member

workingjubilee commented May 7, 2024 •
edited
Loading

cc @rust-lang/rustdoc getting multiple reports of this: #124854

@workingjubilee workingjubilee added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label May 7, 2024
@workingjubilee workingjubilee mentioned this issue May 7, 2024
Open
@ehuss
Copy link
Contributor

ehuss commented May 7, 2024

I believe this regressed in #121218 (@ShoyuVanilla).

@notriddle notriddle mentioned this issue May 7, 2024
Merged
@bors bors closed this as completed in 5347652 May 8, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue May 8, 2024
@rust-timer
Unrolled build for rust-lang#124864
f7c0650 
Rollup merge of rust-lang#124864 - notriddle:notriddle/feature-flags-are-not-stability-markers, r=fmease

rustdoc: use stability, instead of features, to decide what to show

Fixes rust-lang#124635

To decide if internal items should be inlined in a doc page, check if the crate is itself internal, rather than if it has the rustc_private feature flag. The standard library uses internal items, but is not itself internal and should not show internal items on its docs pages.
@valaphee valaphee mentioned this issue May 8, 2024
Closed
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 9, 2024
@LunarLambda
Copy link

This was closed but it's still happening on current stable docs, in various traits, Debug being the one that seems the worst:

Screenshot_20240529_080525
Screenshot_20240529_080433

@ehuss
Copy link
Contributor

ehuss commented May 29, 2024

@LunarLambda What page are you looking at? I do not see those implementations on https://doc.rust-lang.org/nightly/std/fmt/trait.Debug.html.

@LunarLambda
Copy link

LunarLambda commented May 29, 2024 •
edited
Loading

stable docs, not nightly https://doc.rust-lang.org/stable/std/fmt/trait.Debug.html

I understand this was reported the day 1.78.0 was released and 1.79.0 isn't due for a few weeks more, but I feel it should be possible to apply the fix to the current stable docs at least as published on rust-lang.org in the meantime

@ehuss
Copy link
Contributor

ehuss commented May 29, 2024

The stable docs are tied to the release, so we would have to make a new release to update them.

The fix for this is in 1.80, and will reach stable on July 25.

@LunarLambda
Copy link

There's no way to backport it internally? That's unfortunate. I was hoping it would land for 1.79.0 at least

@GuillaumeGomez
Copy link
Member

Closing then.

@workingjubilee
Copy link
Member

There's no way to backport it internally? That's unfortunate. I was hoping it would land for 1.79.0 at least

This can in fact be beta backported.

@workingjubilee
Copy link
Member

And it was in #125183

@LunarLambda
Copy link

Good to know, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: use stability, instead of features, to decide what to show notriddle/rust
8 participants
@ehuss @GuillaumeGomez @apiraino @saethlin @valaphee @LunarLambda @workingjubilee @rustbot