#[coverage(..)] attribute should apply recursively to nested functions/methods/closures
#126625
Labels
A-code-coverage
Area: Source-based code coverage (-Cinstrument-coverage)
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
rustbot
added
needs-triage
This was referenced Jun 18, 2024
jieyouxu
added
C-enhancement
|
Previously filed as #93319. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jun 26, 2024
coverage: Make `#[coverage(..)]` apply recursively to nested functions This PR makes the (currently-unstable) `#[coverage(off)]` and `#[coverage(on)]` attributes apply recursively to all nested functions/closures, instead of just the function they are directly attached to. Those attributes can now also be applied to modules and to impl/impl-trait blocks, where they have no direct effect, but will be inherited by all enclosed functions/closures/methods that don't override the inherited value. --- Fixes rust-lang#126625.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jun 26, 2024
coverage: Make `#[coverage(..)]` apply recursively to nested functions This PR makes the (currently-unstable) `#[coverage(off)]` and `#[coverage(on)]` attributes apply recursively to all nested functions/closures, instead of just the function they are directly attached to. Those attributes can now also be applied to modules and to impl/impl-trait blocks, where they have no direct effect, but will be inherited by all enclosed functions/closures/methods that don't override the inherited value. --- Fixes rust-lang#126625.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jun 27, 2024
Rollup merge of rust-lang#126721 - Zalathar:nested-cov-attr, r=oli-obk coverage: Make `#[coverage(..)]` apply recursively to nested functions This PR makes the (currently-unstable) `#[coverage(off)]` and `#[coverage(on)]` attributes apply recursively to all nested functions/closures, instead of just the function they are directly attached to. Those attributes can now also be applied to modules and to impl/impl-trait blocks, where they have no direct effect, but will be inherited by all enclosed functions/closures/methods that don't override the inherited value. --- Fixes rust-lang#126625.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed at the main tracking issue, #84605 (comment), there is a desire for
#[coverage(off)](and#[coverage(on)]) to apply recursively to all functions/methods/closures inside the one being annotated.The current behaviour is that the attribute only affects the function that it is directly attached to.
@rustbot label +A-code-coverage
The text was updated successfully, but these errors were encountered: