-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"was built for iOS 16.4" warning after updating from 1.79 to 1.80 #128419
Comments
@madsmtm do you know if something happened with our iOS versions? https://doc.rust-lang.org/nightly/rustc/platform-support/apple-ios.html still lists 10.0 as the minimum supported. |
To add more information, the problem is that the
It's worth noting that Before May 8th the compile units didn't have |
Looks like there were a handful of changes to https://github.com/rust-lang/rust/blob/fd8d6fbe505ecf913f5e2ca590c69a7da2789879/compiler/rustc_target/src/spec/base/apple/mod.rs about 4 months ago. #121296 seems like it could have been a candidate. @shepmaster any ideas here? |
I'm going to cross post from here, just to keep everyone up to date:
|
@rustbot label -I-prioritize -regression-untriaged |
I encountered the same problem too. |
#129432 should also tackle this issue (see opening comment) |
Sorry for the long delay here, I wanted to fix this in Have opened #133092 to fix it in bootstrap instead for now. |
…t, r=Mark-Simulacrum Always set the deployment target when building std `cc` has [a bug/feature](rust-lang/cc-rs#1171) (I guess depending on how you look at it) where the default deployment target is taken from the SDK instead of from `rustc`. This causes `compiler-builtins` to build `compiler-rt` with the wrong deployment target on iOS. I've been meaning to change how `cc` works in this regard, but that's a lengthy process, so let's fix it in bootstrap for now. The behaviour be seen locally with `./x build library --set build.optimized-compiler-builtins=true` for various target triples, and then inspecting with `otool -l build/host/stage1/lib/rustlib/*/lib/libcompiler_builtins-*.rlib | rg 'minos|version'`. I have added a rmake test that ensures that we now have the same version everywhere. Fixes rust-lang#128419 Fixes rust-lang/compiler-builtins#650 See also rust-lang/cargo#13115 `@rustbot` label O-apple
Seeing the following type of warning after upgrading from rust 1.79 to 1.80:
THE FULL LIST OF PROBLEMATIC `.o` FILES
Code
I expected not to see an issue with files being built for iOS 16.4 and up only.
Instead, this happened: The compiler complains about the app being built for iOS 15.0 while parts of the binary appear to have been built for iOS 16.4 and up only.
Version it worked on
It most recently worked on: 1.79
Version with regression
1.80
The text was updated successfully, but these errors were encountered: