Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc-json: Change Self type representation #128522

Open
aDotInTheVoid opened this issue Aug 1, 2024 · 0 comments
Open

rustdoc-json: Change Self type representation #128522

aDotInTheVoid opened this issue Aug 1, 2024 · 0 comments
Labels
A-rustdoc-json Area: Rustdoc JSON backend C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@aDotInTheVoid
Copy link
Member

aDotInTheVoid commented Aug 1, 2024 •
edited
Loading

This is fine for now as it preserves the existing behavior, but yeah this should almost certainly be changed in a future PR

Originally posted by @aDotInTheVoid in #128471 (comment)
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 1, 2024
@aDotInTheVoid aDotInTheVoid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. A-rustdoc-json Area: Rustdoc JSON backend and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 1, 2024
@camelid camelid changed the title rustdoc-json: Change self type representation rustdoc-json: Change Self type representation Aug 1, 2024
@aDotInTheVoid aDotInTheVoid mentioned this issue Aug 15, 2024
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Aug 29, 2024
@workingjubilee
Rollup merge of rust-lang#129123 - aDotInTheVoid:rustdoc-json-self, r…
10db657 
…=fmease

rustdoc-json: Add test for `Self` type

Inspired by rust-lang#128471, the rustdoc-json suite had no tests in place for the `Self` type. This PR adds one.

I've also manually checked locally that this test passes on 29e9248, confirming that adding `clean::Type::SelfTy` didn't change the JSON output. (potentially adding a self type to json (insead of (ab)using generic) is tracked in rust-lang#128522)

Updates rust-lang#81359

r? `@fmease`
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Aug 29, 2024
@workingjubilee
Rollup merge of rust-lang#129123 - aDotInTheVoid:rustdoc-json-self, r…
4756a31 
…=fmease

rustdoc-json: Add test for `Self` type

Inspired by rust-lang#128471, the rustdoc-json suite had no tests in place for the `Self` type. This PR adds one.

I've also manually checked locally that this test passes on 29e9248, confirming that adding `clean::Type::SelfTy` didn't change the JSON output. (potentially adding a self type to json (insead of (ab)using generic) is tracked in rust-lang#128522)

Updates rust-lang#81359

r? ``@fmease``
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Aug 30, 2024
@workingjubilee
Rollup merge of rust-lang#129123 - aDotInTheVoid:rustdoc-json-self, r…
4b9e608 
…=fmease

rustdoc-json: Add test for `Self` type

Inspired by rust-lang#128471, the rustdoc-json suite had no tests in place for the `Self` type. This PR adds one.

I've also manually checked locally that this test passes on 29e9248, confirming that adding `clean::Type::SelfTy` didn't change the JSON output. (potentially adding a self type to json (insead of (ab)using generic) is tracked in rust-lang#128522)

Updates rust-lang#81359

r? ```@fmease```
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Aug 30, 2024
@workingjubilee
Rollup merge of rust-lang#129123 - aDotInTheVoid:rustdoc-json-self, r…
e411e44 
…=fmease

rustdoc-json: Add test for `Self` type

Inspired by rust-lang#128471, the rustdoc-json suite had no tests in place for the `Self` type. This PR adds one.

I've also manually checked locally that this test passes on 29e9248, confirming that adding `clean::Type::SelfTy` didn't change the JSON output. (potentially adding a self type to json (insead of (ab)using generic) is tracked in rust-lang#128522)

Updates rust-lang#81359

r? ````@fmease````
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Aug 31, 2024
@workingjubilee
Rollup merge of rust-lang#129123 - aDotInTheVoid:rustdoc-json-self, r…
c3b1336 
…=fmease

rustdoc-json: Add test for `Self` type

Inspired by rust-lang#128471, the rustdoc-json suite had no tests in place for the `Self` type. This PR adds one.

I've also manually checked locally that this test passes on 29e9248, confirming that adding `clean::Type::SelfTy` didn't change the JSON output. (potentially adding a self type to json (insead of (ab)using generic) is tracked in rust-lang#128522)

Updates rust-lang#81359

r? `````@fmease`````
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Aug 31, 2024
@workingjubilee
Rollup merge of rust-lang#129123 - aDotInTheVoid:rustdoc-json-self, r…
303116f 
…=fmease

rustdoc-json: Add test for `Self` type

Inspired by rust-lang#128471, the rustdoc-json suite had no tests in place for the `Self` type. This PR adds one.

I've also manually checked locally that this test passes on 29e9248, confirming that adding `clean::Type::SelfTy` didn't change the JSON output. (potentially adding a self type to json (insead of (ab)using generic) is tracked in rust-lang#128522)

Updates rust-lang#81359

r? ``````@fmease``````
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#129123 - aDotInTheVoid:rustdoc-json-self, r…
e8f19ac 
…=fmease

rustdoc-json: Add test for `Self` type

Inspired by rust-lang#128471, the rustdoc-json suite had no tests in place for the `Self` type. This PR adds one.

I've also manually checked locally that this test passes on 29e9248, confirming that adding `clean::Type::SelfTy` didn't change the JSON output. (potentially adding a self type to json (insead of (ab)using generic) is tracked in rust-lang#128522)

Updates rust-lang#81359

r? ```````@fmease```````
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#129123 - aDotInTheVoid:rustdoc-json-self, r…
defc245 
…=fmease

rustdoc-json: Add test for `Self` type

Inspired by rust-lang#128471, the rustdoc-json suite had no tests in place for the `Self` type. This PR adds one.

I've also manually checked locally that this test passes on 29e9248, confirming that adding `clean::Type::SelfTy` didn't change the JSON output. (potentially adding a self type to json (insead of (ab)using generic) is tracked in rust-lang#128522)

Updates rust-lang#81359

r? ````````@fmease````````
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Aug 31, 2024
@rust-timer
Unrolled build for rust-lang#129123
52b51b8 
Rollup merge of rust-lang#129123 - aDotInTheVoid:rustdoc-json-self, r=fmease

rustdoc-json: Add test for `Self` type

Inspired by rust-lang#128471, the rustdoc-json suite had no tests in place for the `Self` type. This PR adds one.

I've also manually checked locally that this test passes on 29e9248, confirming that adding `clean::Type::SelfTy` didn't change the JSON output. (potentially adding a self type to json (insead of (ab)using generic) is tracked in rust-lang#128522)

Updates rust-lang#81359

r? ````````@fmease````````
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-json Area: Rustdoc JSON backend C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aDotInTheVoid @rustbot