Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: pointee is ambiguous #128888

Closed
BoxyUwU opened this issue Aug 9, 2024 · 5 comments · Fixed by #128925
Closed

regression: pointee is ambiguous #128888

BoxyUwU opened this issue Aug 9, 2024 · 5 comments · Fixed by #128925
Assignees
@dingxiangfei2009
Labels
F-derive_coerce_pointee Feature: RFC 3621's oft-renamed implementation P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented Aug 9, 2024 •
edited by rustbot
Loading 

[INFO] [stdout] error[E0659]: `pointee` is ambiguous
[INFO] [stdout]    --> src/lib.rs:546:11
[INFO] [stdout]     |
[INFO] [stdout] 546 |         #[pointee]
[INFO] [stdout]     |           ^^^^^^^ ambiguous name
[INFO] [stdout]     |
[INFO] [stdout]     = note: ambiguous because of a name conflict with a builtin attribute
[INFO] [stdout]     = note: `pointee` could refer to a built-in attribute

#125575 cc @davidtwco @dingxiangfei2009
@BoxyUwU BoxyUwU added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Aug 9, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 9, 2024
@BoxyUwU BoxyUwU removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 9, 2024
@BoxyUwU BoxyUwU mentioned this issue Aug 9, 2024
Closed
@lqd
Copy link
Member

lqd commented Aug 9, 2024

cc @dingxiangfei2009 @Darksonn

@Darksonn
Copy link
Contributor

Darksonn commented Aug 9, 2024

@rustbot label F-derive_smart_pointer

@rustbot rustbot added the F-derive_coerce_pointee Feature: RFC 3621's oft-renamed implementation label Aug 9, 2024
@Darksonn
Copy link
Contributor

Darksonn commented Aug 9, 2024

Thread on zulip: https://rust-lang.zulipchat.com/#narrow/stream/425075-rust-for-linux/topic/regression.3A.20pointee.20is.20ambiguous/near/459535999

@dingxiangfei2009
Copy link
Contributor

@rustbot claim

@dingxiangfei2009 dingxiangfei2009 mentioned this issue Aug 10, 2024
Merged
@apiraino
Copy link
Contributor

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-high

@rustbot rustbot added P-high High priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Aug 12, 2024
@petrochenkov petrochenkov mentioned this issue Aug 14, 2024
Draft
1 task
@bors bors closed this as completed in 9938349 Aug 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Aug 15, 2024
@rust-timer
Unrolled build for rust-lang#128925
217dcf1 
Rollup merge of rust-lang#128925 - dingxiangfei2009:smart-ptr-helper-attr, r=compiler-errors

derive(SmartPointer): register helper attributes

Fix rust-lang#128888

This PR enables built-in macros to register helper attributes, if any, to support correct name resolution in the correct lexical scope under the macros.

Also, `#[pointee]` is moved into the scope under `derive(SmartPointer)`.

cc `@Darksonn` `@davidtwco`
@Darksonn Darksonn mentioned this issue Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dingxiangfei2009 dingxiangfei2009

Labels
F-derive_coerce_pointee Feature: RFC 3621's oft-renamed implementation P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

derive(SmartPointer): register helper attributes dingxiangfei2009/rust
6 participants
@lqd @Darksonn @apiraino @dingxiangfei2009 @BoxyUwU @rustbot