Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float docs do not define the set of "arithmetic" operations #129699

Closed
RalfJung opened this issue Aug 28, 2024 · 0 comments · Fixed by #129730
Closed

Float docs do not define the set of "arithmetic" operations #129699

RalfJung opened this issue Aug 28, 2024 · 0 comments · Fixed by #129730
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Aug 28, 2024

Pointed out by @workingjubilee in #129683: the float docs are using the term "arithmetic" operations in a few places, but that term is never defined. Furthermore, the new NaN docs probably should use that term as well when discussing which operations the NaN rules apply to (instead of "non-bitwise floating point operations" which they use currently).

By "arithmetic operations", the docs likely mean all operations except for unary -, abs, copysign, signum, {to,from}_bits, {to,from}_{be,le,ne}_bytes and is_sign_{positive,negative}.

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 28, 2024
@saethlin saethlin added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 29, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Aug 31, 2024
…ngjubilee

f32 docs: define 'arithmetic' operations

r? `@workingjubilee`
Fixes rust-lang#129699
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Aug 31, 2024
…ngjubilee

f32 docs: define 'arithmetic' operations

r? ``@workingjubilee``
Fixes rust-lang#129699
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 31, 2024
…ngjubilee

f32 docs: define 'arithmetic' operations

r? ```@workingjubilee```
Fixes rust-lang#129699
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 31, 2024
…ngjubilee

f32 docs: define 'arithmetic' operations

r? ````@workingjubilee````
Fixes rust-lang#129699
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Aug 31, 2024
Rollup merge of rust-lang#129730 - RalfJung:float-arithmetic, r=workingjubilee

f32 docs: define 'arithmetic' operations

r? ````@workingjubilee````
Fixes rust-lang#129699
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Sep 1, 2024
f32 docs: define 'arithmetic' operations

r? ````@workingjubilee````
Fixes rust-lang/rust#129699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants