Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x.py refers to skip-build, which is missing from config.example.toml #130039

Closed
dilyanpalauzov opened this issue Sep 6, 2024 · 2 comments · Fixed by #130059
Closed

x.py refers to skip-build, which is missing from config.example.toml #130039

dilyanpalauzov opened this issue Sep 6, 2024 · 2 comments · Fixed by #130059
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@dilyanpalauzov
Copy link

rustc-1.81.0-src/x.py --help prints

     --llvm-skip-rebuild <VALUE>
          whether rebuilding llvm should be skipped, overriding `skip-rebuld` in config.toml
          
          [possible values: true, false]

This suggests, that config.example.toml has a skip-rebuild parameter. But it does not.

#71119 suggests to skip rebuilding LLVM by calling ./configure --llvm-root=<path>.

  • Either reword the above output, or add skip-rebuild in config,example.toml.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 6, 2024
@dilyanpalauzov
Copy link
Author

It really says skip-rebuld and not skip-rebuild and both are missing from config.example.toml.

@saethlin saethlin added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 6, 2024
@onur-ozkan onur-ozkan added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-help-wanted Call for participation: Help is requested to fix this issue. labels Sep 7, 2024
@onur-ozkan
Copy link
Member

This --llvm-skip-rebuild flag is no longer used anywhere, and we don't support that skip-rebuild option in config.toml.

Mentoring instructions: remove the llvm_skip_rebuild from bootstrap, then run x.py test tidy --bless to update the shell completion files.

@gurry gurry mentioned this issue Sep 7, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Sep 7, 2024
@matthiaskrgr
Rollup merge of rust-lang#130059 - gurry:130039-remove-skip-rebuild, …
4ba483d 
…r=Kobzol

Remove the unused  `llvm-skip-rebuild` option from x.py

Fixes rust-lang#130039
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 8, 2024
@rust-timer
Unrolled build for rust-lang#130059
f0e4543 
Rollup merge of rust-lang#130059 - gurry:130039-remove-skip-rebuild, r=Kobzol

Remove the unused  `llvm-skip-rebuild` option from x.py

Fixes rust-lang#130039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the unused llvm-skip-rebuild option from x.py gurry/rust
4 participants
@dilyanpalauzov @saethlin @onur-ozkan @rustbot