Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: crashes tests should mention COMPILETEST_VERBOSE_CRASHES if no longer crashes #130776

Closed
jieyouxu opened this issue Sep 24, 2024 · 2 comments · Fixed by #130793
Closed

compiletest: crashes tests should mention COMPILETEST_VERBOSE_CRASHES if no longer crashes #130776

jieyouxu opened this issue Sep 24, 2024 · 2 comments · Fixed by #130793
Assignees
@jieyouxu
Labels
A-compiletest Area: The compiletest test runner A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

E.g. if a test doesn't have a main fn it can prevent the test from ICEing because ICEing codepath might not yet be reached before compilation is aborted. In this case, the stderr should be printed to help the person figure out that "I forgor to annotate crate type" is the cause.
@jieyouxu jieyouxu added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 24, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 24, 2024
@jieyouxu jieyouxu changed the title compiletest: crashes tests should orobably still report stderr if the test no longer ICEs compiletest: crashes tests should probably still report stderr if the test no longer ICEs Sep 24, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 24, 2024
@matthiaskrgr
Copy link
Member

you can set COMPILETEST_VERBOSE_CRASHES env var which should print stdout, stderr and exit code

@jieyouxu
Copy link
Member Author

jieyouxu commented Sep 24, 2024 •
edited
Loading

Oh right, good point, I forgor this existed. We should (I'll do this later unless you want to work on it):

EDIT: ended up duplicating some description of `tests/crashes/README.md in rust-lang/rustc-dev-guide#2075 because I would not have thought to look there for docs specifically.

@jieyouxu jieyouxu added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Sep 24, 2024
@jieyouxu jieyouxu changed the title compiletest: crashes tests should probably still report stderr if the test no longer ICEs compiletest: crashes tests should mention COMPILETEST_VERBOSE_CRASHES if no longer crashes Sep 24, 2024
@jieyouxu jieyouxu self-assigned this Sep 24, 2024
@jieyouxu jieyouxu mentioned this issue Sep 24, 2024
Merged
@bors bors closed this as completed in 7de1082 Sep 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 25, 2024
@rust-timer
Unrolled build for rust-lang#130793
239fcf6 
Rollup merge of rust-lang#130793 - jieyouxu:mention-crashes-verbose, r=matthiaskrgr

Mention `COMPILETEST_VERBOSE_CRASHES` on crash test failure

Fixes rust-lang#130776.

r? `@matthiaskrgr` (or compiler/bootstrap)
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Sep 25, 2024
@tgross35
Rollup merge of #130793 - jieyouxu:mention-crashes-verbose, r=matthia…
b627dc5 
…skrgr

Mention `COMPILETEST_VERBOSE_CRASHES` on crash test failure

Fixes rust-lang/rust#130776.

r? `@matthiaskrgr` (or compiler/bootstrap)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
compiletest maintenance and improvements
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mention COMPILETEST_VERBOSE_CRASHES on crash test failure jieyouxu/rust
3 participants
@matthiaskrgr @jieyouxu @rustbot