Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: //@ needs-dynamic-linking should rule out musl since it supports neither dylibs nor cdylibs #132350

Open
jieyouxu opened this issue Oct 30, 2024 · 2 comments
Open

compiletest: //@ needs-dynamic-linking should rule out musl since it supports neither dylibs nor cdylibs #132350

jieyouxu opened this issue Oct 30, 2024 · 2 comments
Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Oct 30, 2024 •
edited
Loading

Noticed in #130860. Should double-check the detection mechanism to determine why we thought musl targets supported dynamic linking in the first place.
@jieyouxu jieyouxu added A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 30, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 30, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 30, 2024
@jieyouxu jieyouxu mentioned this issue Oct 30, 2024
Open
@jieyouxu
Copy link
Member Author

cf. #132309

@bjorn3
Copy link
Member

bjorn3 commented Oct 30, 2024

Musl fully supports dylibs. We are statically linking musl libc by default however, which is not compatible with dylibs. Using -Ctarget-features=-crt-static will link musl dynamically, making dylibs work just fine. We should be migrating to dynamically linking musl in the future to better work with distros that use musl as their libc implementation, but nobody has been working on implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
compiletest maintenance and improvements
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bjorn3 @jieyouxu @rustbot