Fix directives for lint-non-snake-case-crate #130860

tmandry · 2024-09-25T23:29:24Z

This test fails on targets without unwinding or with --target-rustcflags=-Cpanic=abort because the proc macro was compiled as the target, not the host. Some targets were explicitly disabled to pass CI, but these directives are more general.

needs-dynamic-linking is self explanatory
force-host for proc macros
no-prefer-dynamic is apparently also used for proc macros

Note that needs-unwind can also be useful for situations other than proc macros where unwinding is necessary.

r? @jieyouxu

try-job: test-various

compiler-errors · 2024-09-26T01:25:06Z

@bors r+ rollup

bors · 2024-09-26T01:25:08Z

📌 Commit c5925ef has been approved by compiler-errors

It is now in the queue for this repository.

…-errors Fix directives for lint-non-snake-case-crate This test fails on targets without unwinding or with `--target-rustcflags=-Cpanic=abort` because the proc macro was compiled as the target, not the host. Some targets were explicitly disabled to pass CI, but these directives are more general. * `needs-dynamic-linking` is self explanatory * `force-host` for proc macros * `no-prefer-dynamic` is apparently also used for proc macros Note that `needs-unwind` can also be useful for situations other than proc macros where unwinding is necessary. r? `@jieyouxu`

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#130820 (Fix diagnostics for coroutines with () as input.) - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation) - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk) - rust-lang#130860 (Fix directives for lint-non-snake-case-crate) - rust-lang#130861 (Use `mem::offset_of!` for `sockaddr_un.sun_path`) - rust-lang#130865 (Use `&raw` in the standard library) - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs) r? `@ghost` `@rustbot` modify labels: rollup

…-errors Fix directives for lint-non-snake-case-crate This test fails on targets without unwinding or with `--target-rustcflags=-Cpanic=abort` because the proc macro was compiled as the target, not the host. Some targets were explicitly disabled to pass CI, but these directives are more general. * `needs-dynamic-linking` is self explanatory * `force-host` for proc macros * `no-prefer-dynamic` is apparently also used for proc macros Note that `needs-unwind` can also be useful for situations other than proc macros where unwinding is necessary. r? ``@jieyouxu``

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#130820 (Fix diagnostics for coroutines with () as input.) - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation) - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk) - rust-lang#130860 (Fix directives for lint-non-snake-case-crate) - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-09-26T11:29:03Z

@bors r-
#130876 (comment)

jieyouxu · 2024-09-26T11:46:23Z

Apparently needs-dynamic-linking is not equivalent to checking if dylib or cdylib crate types are supported.

In compiletest, needs-dynamic-linking performs a check based on target cfg's dynamic_linking field + --print=cfg --target $TARGET.

However, target cfg has an additional field only_cdylib which, if dynamic_linking is true, indicates that only cdylib crate type is supported and not dylib.

rust/compiler/rustc_target/src/spec/mod.rs

Lines 2148 to 2153 in f2becdf

    
           /// Whether dynamic linking is available on this target. Defaults to false. 
        
           pub dynamic_linking: bool, 
        
           /// Whether dynamic linking can export TLS globals. Defaults to true. 
        
           pub dll_tls_export: bool, 
        
           /// If dynamic linking is available, whether only cdylibs are supported. 
        
           pub only_cdylib: bool,

This is the case for wasm base, dynamic linking is supported but not dylib crate type, only cdylib is supported.

rust/compiler/rustc_target/src/spec/base/wasm.rs

Lines 58 to 62 in f2becdf

    
           // we allow dynamic linking, but only cdylibs. Basically we allow a 
        
           // final library artifact that exports some symbols (a wasm module) but 
        
           // we don't allow intermediate `dylib` crate types 
        
           dynamic_linking: true, 
        
           only_cdylib: true,

In the short-run (for this PR), I think it's okay to keep the ignore-wasm, but please leave me a FIXME that states something like we should add a proper //@ target-supports-crate-type: rlib directive or something.

tmandry · 2024-10-28T21:40:23Z

@bors try

@rustbot ready

Fix directives for lint-non-snake-case-crate This test fails on targets without unwinding or with `--target-rustcflags=-Cpanic=abort` because the proc macro was compiled as the target, not the host. Some targets were explicitly disabled to pass CI, but these directives are more general. * `needs-dynamic-linking` is self explanatory * `force-host` for proc macros * `no-prefer-dynamic` is apparently also used for proc macros Note that `needs-unwind` can also be useful for situations other than proc macros where unwinding is necessary. r? `@jieyouxu` try-job: test-various

bors · 2024-10-28T21:41:35Z

⌛ Trying commit 73dc720 with merge 1a4288e...

bors · 2024-10-28T22:08:24Z

💔 Test failed - checks-actions

tmandry · 2024-10-29T20:33:59Z

@bors try

bors · 2024-10-29T20:35:11Z

⌛ Trying commit 5bab360 with merge 7622f5f...

Fix directives for lint-non-snake-case-crate This test fails on targets without unwinding or with `--target-rustcflags=-Cpanic=abort` because the proc macro was compiled as the target, not the host. Some targets were explicitly disabled to pass CI, but these directives are more general. * `needs-dynamic-linking` is self explanatory * `force-host` for proc macros * `no-prefer-dynamic` is apparently also used for proc macros Note that `needs-unwind` can also be useful for situations other than proc macros where unwinding is necessary. r? `@jieyouxu` try-job: test-various

bors · 2024-10-29T21:12:39Z

💔 Test failed - checks-actions

This test fails on targets without unwinding because the proc macro was compiled as the target, not the host. Some targets were explicitly disabled to pass CI, but these directives are more general. Fixes Fuchsia tests.

tmandry · 2024-10-29T23:40:33Z

@bors try

Fix directives for lint-non-snake-case-crate This test fails on targets without unwinding or with `--target-rustcflags=-Cpanic=abort` because the proc macro was compiled as the target, not the host. Some targets were explicitly disabled to pass CI, but these directives are more general. * `needs-dynamic-linking` is self explanatory * `force-host` for proc macros * `no-prefer-dynamic` is apparently also used for proc macros Note that `needs-unwind` can also be useful for situations other than proc macros where unwinding is necessary. r? `@jieyouxu` try-job: test-various

bors · 2024-10-29T23:41:45Z

⌛ Trying commit d942113 with merge 5ba305c...

bors · 2024-10-30T00:27:27Z

☀️ Try build successful - checks-actions
Build commit: 5ba305c (5ba305cd2b04628b1687bd02cd961fc5abf87884)

tmandry · 2024-10-30T00:31:58Z

@rustbot ready

jieyouxu

Thanks!

jieyouxu · 2024-10-30T03:30:45Z

@bors r+ rollup=iffy

bors · 2024-10-30T03:30:48Z

📌 Commit d942113 has been approved by jieyouxu

It is now in the queue for this repository.

bors · 2024-10-30T10:29:00Z

⌛ Testing commit d942113 with merge 298c746...

bors · 2024-10-30T13:08:52Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 298c746 to master...

rust-timer · 2024-10-30T14:26:14Z

Finished benchmarking commit (298c746): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-1.9%, -0.3%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.6%, secondary 1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.7%	[1.7%, 1.7%]	1
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 782.446s -> 782.512s (0.01%)
Artifact size: 333.66 MiB -> 333.61 MiB (-0.01%)

rustbot assigned jieyouxu Sep 25, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 25, 2024

compiler-errors approved these changes Sep 26, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2024

matthiaskrgr mentioned this pull request Sep 26, 2024

Rollup of 7 pull requests #130871

Closed

matthiaskrgr mentioned this pull request Sep 26, 2024

Rollup of 5 pull requests #130876

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 26, 2024

tmandry force-pushed the fix-directives branch 2 times, most recently from b420120 to 73dc720 Compare October 28, 2024 21:40

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024

This comment has been minimized.

Sign in to view

jieyouxu mentioned this pull request Oct 29, 2024

compiletest: add a proper supports-crate-type: dylib directive #132309

Open

tmandry force-pushed the fix-directives branch from 73dc720 to 5bab360 Compare October 29, 2024 20:33

This comment has been minimized.

Sign in to view

Fix directives for lint-non-snake-case-crate

d942113

This test fails on targets without unwinding because the proc macro was compiled as the target, not the host. Some targets were explicitly disabled to pass CI, but these directives are more general. Fixes Fuchsia tests.

tmandry force-pushed the fix-directives branch from 5bab360 to d942113 Compare October 29, 2024 23:40

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2024

jieyouxu approved these changes Oct 30, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2024

jieyouxu mentioned this pull request Oct 30, 2024

compiletest: //@ needs-dynamic-linking should rule out musl since it supports neither dylibs nor cdylibs #132350

Open

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 30, 2024

bors merged commit 298c746 into rust-lang:master Oct 30, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Oct 30, 2024

tmandry deleted the fix-directives branch October 30, 2024 21:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix directives for lint-non-snake-case-crate #130860

Fix directives for lint-non-snake-case-crate #130860

tmandry commented Sep 25, 2024 •

edited

Loading

compiler-errors commented Sep 26, 2024

bors commented Sep 26, 2024

matthiaskrgr commented Sep 26, 2024

jieyouxu commented Sep 26, 2024

tmandry commented Oct 28, 2024

bors commented Oct 28, 2024

This comment has been minimized.

bors commented Oct 28, 2024

This comment has been minimized.

tmandry commented Oct 29, 2024

bors commented Oct 29, 2024

This comment has been minimized.

bors commented Oct 29, 2024

tmandry commented Oct 29, 2024

bors commented Oct 29, 2024

bors commented Oct 30, 2024

tmandry commented Oct 30, 2024

jieyouxu left a comment

jieyouxu commented Oct 30, 2024

bors commented Oct 30, 2024

bors commented Oct 30, 2024

bors commented Oct 30, 2024

rust-timer commented Oct 30, 2024

Fix directives for lint-non-snake-case-crate #130860

Fix directives for lint-non-snake-case-crate #130860

Conversation

tmandry commented Sep 25, 2024 • edited Loading

compiler-errors commented Sep 26, 2024

bors commented Sep 26, 2024

matthiaskrgr commented Sep 26, 2024

jieyouxu commented Sep 26, 2024

tmandry commented Oct 28, 2024

bors commented Oct 28, 2024

This comment has been minimized.

bors commented Oct 28, 2024

This comment has been minimized.

tmandry commented Oct 29, 2024

bors commented Oct 29, 2024

This comment has been minimized.

bors commented Oct 29, 2024

tmandry commented Oct 29, 2024

bors commented Oct 29, 2024

bors commented Oct 30, 2024

tmandry commented Oct 30, 2024

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu commented Oct 30, 2024

bors commented Oct 30, 2024

bors commented Oct 30, 2024

bors commented Oct 30, 2024

rust-timer commented Oct 30, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

tmandry commented Sep 25, 2024 •

edited

Loading