Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./x test --skip is sensitive to path separators on Windows #134198

Closed
ChrisDenton opened this issue Dec 12, 2024 · 3 comments · Fixed by #134209
Closed

./x test --skip is sensitive to path separators on Windows #134198

ChrisDenton opened this issue Dec 12, 2024 · 3 comments · Fixed by #134209
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@ChrisDenton
Copy link
Member

ChrisDenton commented Dec 12, 2024 •
edited
Loading

Currently the following will not skip any tests on Windows even though the test path exists

./x test ui --skip tests/ui/traits/fn-pointer/bare-fn-no-impl-fn-ptr-99875.rs

This is because of using / instead of \ for the path separators. Ideally bootstrap should handle this.

Additionally it would be nice if --skip errored (or at least warned) if the given path didn't match anything.
@ChrisDenton ChrisDenton added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 12, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 12, 2024
@jieyouxu jieyouxu added O-windows Operating system: Windows C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 12, 2024
@onur-ozkan onur-ozkan mentioned this issue Dec 12, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#134209 - onur-ozkan:check-skip-paths, r=jie…
5943660 
…youxu

validate `--skip` and `--exclude` paths

Fixes rust-lang#134198

cc `@ChrisDenton`
compiler-errors added a commit to compiler-errors/rust that referenced this issue Dec 13, 2024
@compiler-errors
Rollup merge of rust-lang#134209 - onur-ozkan:check-skip-paths, r=jie…
e80c4f8 
…youxu

validate `--skip` and `--exclude` paths

Fixes rust-lang#134198

cc ``@ChrisDenton``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 13, 2024
@matthiaskrgr
Rollup merge of rust-lang#134209 - onur-ozkan:check-skip-paths, r=jie…
2691abb 
…youxu

validate `--skip` and `--exclude` paths

Fixes rust-lang#134198

cc `@ChrisDenton`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 14, 2024
@matthiaskrgr
Rollup merge of rust-lang#134209 - onur-ozkan:check-skip-paths, r=jie…
9a66fb2 
…youxu

validate `--skip` and `--exclude` paths

Fixes rust-lang#134198

cc ```@ChrisDenton```
@bors bors closed this as completed in 6cf13b0 Dec 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 14, 2024
@rust-timer
Unrolled build for rust-lang#134209
92d4650 
Rollup merge of rust-lang#134209 - onur-ozkan:check-skip-paths, r=jieyouxu

validate `--skip` and `--exclude` paths

Fixes rust-lang#134198

cc ``@ChrisDenton``
@jieyouxu
Copy link
Member

Reopening because this is a bit more tricky, as Steps may register arbitrary aliases and there is also logic that accepts matching prefix/suffixes for tests (see #134843 for more details).

@jieyouxu jieyouxu reopened this Dec 28, 2024
@jieyouxu jieyouxu mentioned this issue Dec 28, 2024
Closed
@onur-ozkan
Copy link
Member

The fix doesn't have anything to do with aliases.

@jieyouxu
Copy link
Member

Indeed, please disregard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

validate --skip and --exclude paths onur-ozkan/rust
4 participants
@ChrisDenton @jieyouxu @onur-ozkan @rustbot