-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to re-allow false positives in crate loading. #13764
Comments
The compiler doesn't understand that these are false positives, this is a legitimate error that the compiler is emitting. The compiler has no way of knowing whether those two files are exactly the same (short of comparing the contents). Why do you think this is not a bug? Are those two files symlinks to one another? |
So give me the option to tell the compiler which one to use or which one to ignore. The rest of the world is fine using the first one on the command line, but I can understand why that won't work for Rust after seeing the Makefiles. If you actually think two third-party |
In that case, I'm tempted to close this in favor of #13733. The way you tell the compiler which one to ignore is by controlling what the The point of versions and hashes are two disambiguate two libraries with the same and version, but likely a different source (encoded in the crate ID). It sounds like there's some build business going on which needs to sort out the Can you explain your build setup in some more detail? I don't quite understand what you're doing or how things are set up, and that may help more in understanding what's going on here. |
The problem was my wishful thinking in trying to treat Rust libraries like regular system libraries, and there may be some badness in the way Paludis expects builds to happen too. I am indeed way too generous with my In any case, this would be solved by #11802. I should not have opened this one. My apologies. |
No worries! Feel free to keep opening issues, we want rust to be easy to package! |
To elaborate on the build system, in an ideal world there is an exheres (bash) library called SCM_REPOSITORY="git://github.com/alexcrichton/rs-splay"
require scm-git
require rust
SUMMARY="A splay tree implementation written in Rust"
HOMEPAGE="https://github.com/alexcrichton/rs-splay"
LICENCES="MIT"
SLOT="0"
PLATFORMS="~amd64 ~x86"
BUGS_TO="jurily@gmail.com"
src_compile() {
# relative path + crate_id
rust_lib_compile lib.rs splay
}
src_test() {
rust_test splay
}
src_install() {
rust_lib_install splay
} ...except I now have next to no idea how to sanitize the build environment in a generic manner. Back to RTFM, I guess. |
fix: Correctly check for parentheses redundancy in `remove_parentheses` assist This is quite a bunch of code and some hacks, but I _think_ this time it's correct. I've added a lot of tests, most of which fail with the assist impl from rust-lang#13733 :')
When trying to reinstall
rust-sdl
:Introduced by #13017, combined with #11802 this is a packaging showstopper. If a package and its dependency are installed to the same directory, there is no way to rebuild it without recursively uninstalling everything first.
Also, these are
rlib
s.The text was updated successfully, but these errors were encountered: