Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rustc crate crate_type to "lib". Stop passing --lib #1533

Closed
brson opened this issue Jan 15, 2012 · 1 comment
Closed

Change rustc crate crate_type to "lib". Stop passing --lib #1533

brson opened this issue Jan 15, 2012 · 1 comment
Assignees
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jan 15, 2012

The main rustc crate is always used as a library now. To do this we probably want to fix #1444 as well so we don't have to pass --bin when testing.

@ghost ghost assigned brson Jan 17, 2012
@brson
Copy link
Contributor Author

brson commented Jan 17, 2012

Done.

@brson brson closed this as completed Jan 17, 2012
bors added a commit that referenced this issue Aug 8, 2019
Update RLS

Most importantly this includes:
* Collect file -> edition mapping after AST expansion ([#1513](rust-lang/rls#1513)) (enabled by #62679)
* Fix rustfmt during builds by reading edition from manifest ([#1533](rust-lang/rls#1533))

Which fixes the annoying problem where users couldn't format via RLS while `cargo fmt` worked.

The beta cut-off is drawing near and I'd like to make sure this lands before then.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

1 participant