Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "benchmarks game" results return #15408

Closed
kud1ing opened this issue Jul 4, 2014 · 15 comments
Closed

Make "benchmarks game" results return #15408

kud1ing opened this issue Jul 4, 2014 · 15 comments

Comments

@kud1ing
Copy link

kud1ing commented Jul 4, 2014

http://benchmarksgame.alioth.debian.org/u64q/rust.php does not show any results anymore. AFAIK this was initally due to a licensing situation, which was resolved in #14248

What needs to be done in order to make the results come back?

@kud1ing kud1ing changed the title Make "benchmark games" results return Make "benchmarks game" results return Jul 4, 2014
@kud1ing
Copy link
Author

kud1ing commented Jul 9, 2014

@TeXitoi
Copy link
Contributor

TeXitoi commented Jul 9, 2014

cc @Ryman

@TeXitoi
Copy link
Contributor

TeXitoi commented Jul 9, 2014

@kud1ing meteor contest, that does not appear in the table, is also back. nbody is not our version.

bors added a commit that referenced this issue Jul 18, 2014
Matches the official sample output (N=200) again.

cc #15408
@Ryman
Copy link
Contributor

Ryman commented Jul 19, 2014

@TeXitoi Mandelbrot should be ok again now on master

@TeXitoi
Copy link
Contributor

TeXitoi commented Oct 11, 2014

Most of the benchmarks are back for 0.12. fasta-redux just don't work so I didn't submitted it. mandelbrot gives bad output on x86.

@Ryman do you have an idea about this problem: http://benchmarksgame.alioth.debian.org/u32/program.php?test=mandelbrot&lang=rust&id=1#log

SIMD bug?

@Ryman
Copy link
Contributor

Ryman commented Oct 12, 2014

@TeXitoi I looked into this, and cross compiled it a number of times on my machine. Seems like sse2 isn't being used for the x86 build and the floating point calculations are using x87 (which leads to 80bit precision for intermediates rather than 64bit as expected by the benchmark).

I've gotten it to work locally by adding -C target-feature=+sse2 to the rustc arguments, you should be able to add that to the benchmark to get the correct output.

@TeXitoi
Copy link
Contributor

TeXitoi commented Oct 12, 2014

@Ryman thanks for the investigation! I've asked to add these command line flags https://alioth.debian.org/tracker/index.php?func=detail&aid=314839&group_id=100815&atid=413122

@TeXitoi
Copy link
Contributor

TeXitoi commented Oct 12, 2014

@Ryman and congrats to your mandelbrot implementation: 2nd on 4 core amd64 http://benchmarksgame.alioth.debian.org/u64q/benchmark.php?test=mandelbrot&lang=all&data=u64q

@thestinger
Copy link
Contributor

@TeXitoi: Using target-feature is definitely the wrong way to do it. It should be using target-cpu, not enabling individual features.

@thestinger
Copy link
Contributor

Using target-cpu gives it all of the features available on that CPU (not just SSE2) and makes it use the correct cost model. The C code is compiled with -march=native so the Rust code should be using core2 as the target (or whatever the correct one is for the benchmarks game computers).

@Ryman
Copy link
Contributor

Ryman commented Oct 12, 2014

Can confirm that I get the same results with -C target-cpu=core2 on an i5 (with i686-apple-darwin), thanks @thestinger!

@TeXitoi
Copy link
Contributor

TeXitoi commented Oct 16, 2014

Maybe we can close this issue in favor of #18085 ?

@thestinger
Copy link
Contributor

Sure, it covers the same thing. I altered the title a bit to include the fact that one is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants