Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphan rules in coherence do not account for multidispatch #18222

Closed
nikomatsakis opened this issue Oct 22, 2014 · 0 comments
Closed

Orphan rules in coherence do not account for multidispatch #18222

nikomatsakis opened this issue Oct 22, 2014 · 0 comments

Comments

@nikomatsakis
Copy link
Contributor

The current orphan rules orphan rulees do not account for multidispatch. They should accept an impl if at least one input type is local to the current crate. Currently they require the self type specifically to be local. This is just a simple oversight.
@nikomatsakis nikomatsakis mentioned this issue Oct 22, 2014
Closed
5 tasks
@nikomatsakis nikomatsakis mentioned this issue Oct 22, 2014
Closed
bors added a commit that referenced this issue Oct 22, 2014
@bors
auto merge of #18223 : nikomatsakis/rust/coherence-orphan-18222, r=pc…
d44ea72 
…walton

Adjust orphan rules to consider all input types, not just self type.

Fixes #18222.

r? @pcwalton
lnicola pushed a commit to lnicola/rust that referenced this issue Oct 17, 2024
@mrkajetanp
fix: Join rustfmt overrideCommand with project root
96d667b 
When providing a custom rustfmt command, join it with the project
root instead of the workspace root. This fixes rust-analyzer
getting the wrong invocation path in projects containing subprojects.

This makes the behaviour consistent with how a custom path provided
in rust-analyzer.procMacro.server behaves already.

Resolves issue rust-lang#18222
lnicola pushed a commit to lnicola/rust that referenced this issue Oct 17, 2024
@bors
Auto merge of rust-lang#18229 - mrkajetanp:rustfmt-path, r=Veykril
1ef2712 
fix: Join rustfmt overrideCommand with project root

When providing a custom rustfmt command, join it with the project root instead of the workspace root. This fixes rust-analyzer getting the wrong invocation path in projects containing subprojects.

This makes the behaviour consistent with how a custom path provided in rust-analyzer.procMacro.server behaves already.

Resolves issue rust-lang#18222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust orphan rules to consider all input types, not just self type. nikomatsakis/rust
1 participant
@nikomatsakis