Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-clonable FileType #18619

Closed
3Hren opened this issue Nov 4, 2014 · 3 comments · Fixed by #18691
Closed

Non-clonable FileType #18619

3Hren opened this issue Nov 4, 2014 · 3 comments · Fixed by #18691
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@3Hren
Copy link
Contributor

3Hren commented Nov 4, 2014

Hi guys!

Is there any reasons, why FileType (https://github.com/rust-lang/rust/blob/master/src/libstd/io/mod.rs#L1740) can't be cloned?

It is the only non-clonable part of FileStat, which makes the entire struct non-clonable either.
@sfackler sfackler added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-libs labels Nov 4, 2014
@sfackler
Copy link
Member

sfackler commented Nov 4, 2014

Looks like an oversight.

CC #15294

@subhashb
Copy link

subhashb commented Nov 6, 2014

Hey!
If this is confirmed as oversight, can I add Clone trait to FileType and address this issue? Or should this be addressed as part of #15294?

@sfackler
Copy link
Member

sfackler commented Nov 6, 2014

Go for it! #15294 isn't something that'll be fixed in one commit, it's an ongoing effort.

This was referenced Nov 6, 2014
Closed
Merged
lnicola pushed a commit to lnicola/rust that referenced this issue Dec 11, 2024
@Veykril
Merge pull request rust-lang#18619 from ShoyuVanilla/issue-18613
f9351a8 
fix: Panic when displaying generic params with defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Filetype Clonable
Make FileType Clonable
3 participants
@subhashb @3Hren @sfackler